You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/10/10 22:05:34 UTC

[jira] [Commented] (THRIFT-2782) D: Timing-insensitive unit tests for thrift.internal.resource_pool

    [ https://issues.apache.org/jira/browse/THRIFT-2782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167421#comment-14167421 ] 

ASF GitHub Bot commented on THRIFT-2782:
----------------------------------------

GitHub user klickverbot opened a pull request:

    https://github.com/apache/thrift/pull/245

    THRIFT-2782: D: Timing-insensitive unit tests for thrift.internal.resource_pool.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klickverbot/thrift resourcepool-unittest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
    
----
commit 07914763b8dbe55c5c28c3cf0ed06ab3e32374de
Author: David Nadlinger <co...@klickverbot.at>
Date:   2014-10-10T19:32:49Z

    THRIFT-2782: D: Timing-insensitive unit tests for thrift.internal.resource_pool.

commit 8b922b925a576c106e7c03af5a50795144504e61
Author: David Nadlinger <co...@klickverbot.at>
Date:   2014-10-10T19:45:03Z

    D: Fix TResourcePool.Range.willBecomeNonempty for empty pools.
    
    This is mostly just for good feelings, as a client pool without
    any members isn't something a Thrift user would ever need to
    work correctly.

commit 1460c3f043e6200cd04017670a83cb52a04f8d23
Author: David Nadlinger <co...@klickverbot.at>
Date:   2014-10-10T19:59:40Z

    D: Minor code cleanup in thrift.internal.resource_pool.
    
    Because of oddities in the standard library at the time Thrift/D
    was written the code was a bit uglier than necessary.

----


> D: Timing-insensitive unit tests for thrift.internal.resource_pool
> ------------------------------------------------------------------
>
>                 Key: THRIFT-2782
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2782
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>            Reporter: David Nadlinger
>            Priority: Minor
>
> See https://issues.apache.org/jira/browse/THRIFT-2776.
> Pull request incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)