You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/05 23:45:45 UTC
[GitHub] [arrow-rs] thinkharderdev opened a new pull request, #2656: Fix flaky test `test_fuzz_async_reader_selection`
thinkharderdev opened a new pull request, #2656:
URL: https://github.com/apache/arrow-rs/pull/2656
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Fixes flaky fuzz test for row selection. Was generating random row selections with `row_count` equal to 0 which mucks things up.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656#discussion_r963163796
##########
parquet/src/arrow/async_reader.rs:
##########
@@ -1015,7 +1014,7 @@ mod tests {
let mut selectors = vec![];
while total_rows < 7300 {
- let row_count: usize = rand.gen_range(0..100);
+ let row_count: usize = rand.gen_range(1..100);
Review Comment:
So `RowSelector.row_count` cannot be 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656#issuecomment-1238170699
Benchmark runs are scheduled for baseline = 31aaef2733ee2bb1804f9f38600a539604cf177d and contender = a37c038c6a8076987c9e8f2a357e700d7edb4893. a37c038c6a8076987c9e8f2a357e700d7edb4893 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9c61dc61279f4fc3b8f2471b440bee21...97ff9e3e60da4884b3ae6213d18cc094/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d4b6a81bb5854b149c76b76966ef37a1...9a3ff8a8b52249d6ae521d2608c1b323/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0291cf9de8ed48b796f54efe2d6d8238...9ba5fdc1f5bb4267911d83080e8222b2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/63b424ef6d144304958da367c8b55817...9248535f984640df8dc5210415a013b8/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] thinkharderdev commented on pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656#issuecomment-1237529407
@tustvold FYI. This should fix the flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] thinkharderdev commented on a diff in pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on code in PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656#discussion_r963571815
##########
parquet/src/arrow/async_reader.rs:
##########
@@ -1015,7 +1014,7 @@ mod tests {
let mut selectors = vec![];
while total_rows < 7300 {
- let row_count: usize = rand.gen_range(0..100);
+ let row_count: usize = rand.gen_range(1..100);
Review Comment:
It can if you manually construct one as we do in this test but in practice it would be non-sensical (and you wouldn't ever get one if you built a `RowSelection` from ranges or `BooleanArray`s). So depending on your perspective we could consider this a bug in the `ParquetRecordBatchReader` (probably, not sure where the actual issue comes up) but I think if we did the solution would be to just disallow row counts of 0 explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656#discussion_r963722008
##########
parquet/src/arrow/async_reader.rs:
##########
@@ -1015,7 +1014,7 @@ mod tests {
let mut selectors = vec![];
while total_rows < 7300 {
- let row_count: usize = rand.gen_range(0..100);
+ let row_count: usize = rand.gen_range(1..100);
Review Comment:
Perhaps you could file a ticket describing the issue, I agree it isn't urgent but it should probably be looked into eventually (as it might unveil other issues).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2656:
URL: https://github.com/apache/arrow-rs/pull/2656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org