You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Michael Osipov <mi...@apache.org> on 2021/02/01 10:42:48 UTC
Re: jvm.config and spaces
Am 2021-01-29 um 21:51 schrieb Romain Manni-Bucau:
> Hi all,
>
> Is it intended our jvm.config impl does not support spaces?
>
> -Dfoo=bar dummy
> "-Dfoo=bar dummy"
> '-Dfoo=bar dummy'
> -Dfoo=bar\ dummy
Likely related to https://issues.apache.org/jira/browse/MNG-4559.
I see no way to solve this with POSIX shell or I am too stupid. One
either needs a bash/zsh based script, or a C-based launcher.
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: jvm.config and spaces
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Why? This is not about changing IFS for maven opts but for jvm.config read
then all the script still uses the default. It is very close to just
writing the jvm.config parsing instead of just handling it with a pipe
bypassing needed escaping, no?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 1 févr. 2021 à 11:59, Michael Osipov <mi...@apache.org> a écrit :
> Am 2021-02-01 um 11:47 schrieb Benjamin Marwell:
> > Eval is probably needed,
> > just look at how open liberty merges those lines [1].
> >
> > As a user, I would expect spaces and comments to be supported.
> >
> > [1]:
> https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.ibm.ws.kernel.boot.ws-server/publish/bin/server#L695-L716
> > EPLv1 licensed
>
> I'd be happy if someone could this picked up. This operates on changing
> IFS. For MAVEN_OPTS this will not work, sadly.
>
> > Am Mo., 1. Feb. 2021 um 11:42 Uhr schrieb Michael Osipov <
> michaelo@apache.org>:
> >>
> >> Am 2021-01-29 um 21:51 schrieb Romain Manni-Bucau:
> >>> Hi all,
> >>>
> >>> Is it intended our jvm.config impl does not support spaces?
> >>>
> >>> -Dfoo=bar dummy
> >>> "-Dfoo=bar dummy"
> >>> '-Dfoo=bar dummy'
> >>> -Dfoo=bar\ dummy
> >>
> >> Likely related to https://issues.apache.org/jira/browse/MNG-4559.
> >> I see no way to solve this with POSIX shell or I am too stupid. One
> >> either needs a bash/zsh based script, or a C-based launcher.
> >>
> >> M
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: jvm.config and spaces
Posted by Michael Osipov <mi...@apache.org>.
Am 2021-02-01 um 11:47 schrieb Benjamin Marwell:
> Eval is probably needed,
> just look at how open liberty merges those lines [1].
>
> As a user, I would expect spaces and comments to be supported.
>
> [1]: https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.ibm.ws.kernel.boot.ws-server/publish/bin/server#L695-L716
> EPLv1 licensed
I'd be happy if someone could this picked up. This operates on changing
IFS. For MAVEN_OPTS this will not work, sadly.
> Am Mo., 1. Feb. 2021 um 11:42 Uhr schrieb Michael Osipov <mi...@apache.org>:
>>
>> Am 2021-01-29 um 21:51 schrieb Romain Manni-Bucau:
>>> Hi all,
>>>
>>> Is it intended our jvm.config impl does not support spaces?
>>>
>>> -Dfoo=bar dummy
>>> "-Dfoo=bar dummy"
>>> '-Dfoo=bar dummy'
>>> -Dfoo=bar\ dummy
>>
>> Likely related to https://issues.apache.org/jira/browse/MNG-4559.
>> I see no way to solve this with POSIX shell or I am too stupid. One
>> either needs a bash/zsh based script, or a C-based launcher.
>>
>> M
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: jvm.config and spaces
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 to do something close to IBM script or have a graalvm light launcher (if
we manage to make it < 10M but I doubt :().
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 1 févr. 2021 à 11:47, Benjamin Marwell <bm...@apache.org> a
écrit :
> Eval is probably needed,
> just look at how open liberty merges those lines [1].
>
> As a user, I would expect spaces and comments to be supported.
>
> [1]:
> https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.ibm.ws.kernel.boot.ws-server/publish/bin/server#L695-L716
> EPLv1
> <https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.ibm.ws.kernel.boot.ws-server/publish/bin/server#L695-L716EPLv1>
> licensed
>
> Am Mo., 1. Feb. 2021 um 11:42 Uhr schrieb Michael Osipov <
> michaelo@apache.org>:
> >
> > Am 2021-01-29 um 21:51 schrieb Romain Manni-Bucau:
> > > Hi all,
> > >
> > > Is it intended our jvm.config impl does not support spaces?
> > >
> > > -Dfoo=bar dummy
> > > "-Dfoo=bar dummy"
> > > '-Dfoo=bar dummy'
> > > -Dfoo=bar\ dummy
> >
> > Likely related to https://issues.apache.org/jira/browse/MNG-4559.
> > I see no way to solve this with POSIX shell or I am too stupid. One
> > either needs a bash/zsh based script, or a C-based launcher.
> >
> > M
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: jvm.config and spaces
Posted by Benjamin Marwell <bm...@apache.org>.
Eval is probably needed,
just look at how open liberty merges those lines [1].
As a user, I would expect spaces and comments to be supported.
[1]: https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.ibm.ws.kernel.boot.ws-server/publish/bin/server#L695-L716
EPLv1 licensed
Am Mo., 1. Feb. 2021 um 11:42 Uhr schrieb Michael Osipov <mi...@apache.org>:
>
> Am 2021-01-29 um 21:51 schrieb Romain Manni-Bucau:
> > Hi all,
> >
> > Is it intended our jvm.config impl does not support spaces?
> >
> > -Dfoo=bar dummy
> > "-Dfoo=bar dummy"
> > '-Dfoo=bar dummy'
> > -Dfoo=bar\ dummy
>
> Likely related to https://issues.apache.org/jira/browse/MNG-4559.
> I see no way to solve this with POSIX shell or I am too stupid. One
> either needs a bash/zsh based script, or a C-based launcher.
>
> M
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org