You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/01/15 03:23:03 UTC
[GitHub] zeppelin pull request #1900: [ZEPPELIN-1969] Can not change visualization pa...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1900
[ZEPPELIN-1969] Can not change visualization package version.
### What is this PR for?
Changing visualization package version from helium menu, sometimes fail.
This PR fixes the problem and providing a unittest.
### What type of PR is it?
Bug Fix
### Todos
* [x] - remove package from node_module and let npm download again before bundle the package.
* [x] - ad dunittest.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1969
### How should this be tested?
Unittest HeliumVisualizationFactoryTest.switchVersion() ensure the fix.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin fix_helium_version_switch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1900.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1900
----
commit e9f2811967ee6b8ec60564b9efe5d80386fd2fc2
Author: Lee moon soo <mo...@apache.org>
Date: 2017-01-15T03:11:38Z
Make download package everytime bundle to workaround inconsistent behavior of npm install
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1900: [ZEPPELIN-1969] Can not change visualization package v...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1900
I hit the same issue! Thanks for fixing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1900: [ZEPPELIN-1969] Can not change visualization pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1900: [ZEPPELIN-1969] Can not change visualization package v...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1900
CI failures are irrelevant.
Merge to master and branch-0.7 if no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---