You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by Bertrand Delacretaz <bd...@apache.org> on 2021/07/12 07:13:02 UTC

[VOTE] promote o.a.s.graphql.schema.aggregator to its own module

Hi,

This is a vote to promote org.apache.sling.graphql.schema.aggregator
to its own Sling module.

I'm finishing work on a first version of that module, which aggregates
GraphQL schemas to allow multiple modules to each contribute parts of
a schema.

The current code is at
https://github.com/apache/sling-whiteboard/tree/master/sling-org-apache-sling-graphql-schema

Proposed Maven module name: org.apache.sling.graphql.schema.aggregator

Proposed Git repository name: sling-org-apache-sling-graphql-schema-aggregator

Please cast your votes:

  [ ] +1 Approve the promotion
  [ ]  0 Don't care
  [ ] -1 Don't promote, because ...

This is a majority vote open for at least 72h.

Here's my +1

-Bertrand

Re: [VOTE] promote o.a.s.graphql.schema.aggregator to its own module

Posted by Robert Munteanu <ro...@apache.org>.

On Mon, 2021-07-12 at 09:13 +0200, Bertrand Delacretaz wrote:
> Please cast your votes:

+1

Thanks,
Robert

Questions on o.a.s.graphq.schema.aggregator (was: [VOTE] promote o.a.s.graphql.schema.aggregator to its own module)

Posted by Robert Munteanu <ro...@apache.org>.

Hi Bertrand,

I took a quick look at the new module, I have a couple of questions:

- there is an API package at [1], but it's not exported. Is that
intended?
- do the dev notes at [2] still need to be there? Your message
indicates that it's "done"

Also, it would be nice to update the documentation before the first
release, rather than asking the user to look at the tests :-)

Thanks,
Robert

[1]:
https://github.com/apache/sling-whiteboard/tree/master/sling-org-apache-sling-graphql-schema/src/main/java/org/apache/sling/graphql/schema/aggregator/api

Re: [VOTE] promote o.a.s.graphql.schema.aggregator to its own module

Posted by Daniel Klco <dk...@apache.org>.

+1

On Wed, Jul 14, 2021 at 5:05 AM Radu Cotescu <ra...@apache.org> wrote:

> +1
>
> > On 12 Jul 2021, at 09:13, Bertrand Delacretaz <bd...@apache.org>
> wrote:
> >
> > Please cast your votes:
> >
> >  [ ] +1 Approve the promotion
> >  [ ]  0 Don't care
> >  [ ] -1 Don't promote, because ...
>
>

Re: [VOTE] promote o.a.s.graphql.schema.aggregator to its own module

Posted by Radu Cotescu <ra...@apache.org>.

+1

> On 12 Jul 2021, at 09:13, Bertrand Delacretaz <bd...@apache.org> wrote:
> 
> Please cast your votes:
> 
>  [ ] +1 Approve the promotion
>  [ ]  0 Don't care
>  [ ] -1 Don't promote, because ...

Re: [VOTE] promote o.a.s.graphql.schema.aggregator to its own module

Posted by Bertrand Delacretaz <bd...@apache.org>.

On Mon, Jul 12, 2021 at 9:13 AM Bertrand Delacretaz
<bd...@apache.org> wrote:
> This is a vote to promote org.apache.sling.graphql.schema.aggregator
> to its own Sling module.

The vote passes with 4 +1s and no other votes, thank you!

The new repository will be at
https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator

-Bertrand