You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/07/16 10:05:38 UTC

svn commit: r1902771 - in /poi/trunk: poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/ poi-ooxml/src/test/java/org/apache/poi/xssf/util/ poi/src/main/java/org/apache/poi/ss/util/ poi/src/test/java/org/apache/poi/ss/formula/

Author: fanningpj
Date: Sat Jul 16 10:05:38 2022
New Revision: 1902771

URL: http://svn.apache.org/viewvc?rev=1902771&view=rev
Log:
[github-346] Javadoc issues. Thanks to XenoAmess. This closes #346

Modified:
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestContentType.java
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/util/MemoryUsage.java
    poi/trunk/poi/src/main/java/org/apache/poi/ss/util/MutableFPNumber.java
    poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/BaseTestExternalFunctions.java

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestContentType.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestContentType.java?rev=1902771&r1=1902770&r2=1902771&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestContentType.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestContentType.java Sat Jul 16 10:05:38 2022
@@ -87,7 +87,7 @@ public final class TestContentType {
      * Parameters are allowed, provides that they meet the
      * criteria of rule [01.2]
      * Invalid parameters are verified as incorrect in
-     * {@link #testContentTypeParameterFailure()}
+     * {@link #testContentTypeParameterFailure(String)}
      */
     @ParameterizedTest
     @ValueSource(strings = {"mail/toto;titi=tata",

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/util/MemoryUsage.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/util/MemoryUsage.java?rev=1902771&r1=1902770&r2=1902771&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/util/MemoryUsage.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/util/MemoryUsage.java Sat Jul 16 10:05:38 2022
@@ -53,7 +53,7 @@ public class MemoryUsage {
 
     /**
      * Generate a spreadsheet until OutOfMemoryError using low-level OOXML XmlBeans.
-     * Similar to {@link #numberSpreadsheet(org.apache.poi.ss.usermodel.Workbook, int)}
+     * Similar to {@link #testNumberHSSF(boolean)} (org.apache.poi.ss.usermodel.Workbook, int)}
      *
      * <p>
      *
@@ -171,12 +171,11 @@ public class MemoryUsage {
      * Generate a spreadsheet who's all cell values are numbers.
      * The data is generated until OutOfMemoryError.
      * <p>
-     * as compared to {@link #mixedSpreadsheet(org.apache.poi.ss.usermodel.Workbook, int)},
+     * as compared to {@link #testMixed},
      * this method does not set string values and, hence, does not involve the Shared Strings Table.
      * </p>
      *
-     * @param wb        the workbook to write to
-     * @param numCols   the number of columns in a row
+     * @param useXSSF   use XSSF as opposed to HSSF
      */
     @ParameterizedTest
     @ValueSource(booleans = {false, true})

Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/util/MutableFPNumber.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/util/MutableFPNumber.java?rev=1902771&r1=1902770&r2=1902771&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/util/MutableFPNumber.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/util/MutableFPNumber.java Sat Jul 16 10:05:38 2022
@@ -25,7 +25,7 @@ final class MutableFPNumber {
     // TODO - what about values between (10<sup>14</sup>-0.5) and (10<sup>14</sup>-0.05) ?
     /**
      * The minimum value in 'Base-10 normalised form'.<br>
-     * When {@link #_binaryExponent} == 46 this is the minimum {@link #_frac} value
+     * When {@link #_binaryExponent} == 46 this is the minimum {@link #_significand} value
      *  (10<sup>14</sup>-0.05) * 2^17
      *  <br>
      *  Values between (10<sup>14</sup>-0.05) and 10<sup>14</sup> will be represented as '1'
@@ -37,7 +37,7 @@ final class MutableFPNumber {
     private static final BigInteger BI_MIN_BASE = new BigInteger("0B5E620F47FFFE666", 16);
     /**
      * For 'Base-10 normalised form'<br>
-     * The maximum {@link #_frac} value when {@link #_binaryExponent} == 49
+     * The maximum {@link #_significand} value when {@link #_binaryExponent} == 49
      * (10^15-0.5) * 2^14
      */
     private static final BigInteger BI_MAX_BASE = new BigInteger("0E35FA9319FFFE000", 16);

Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/BaseTestExternalFunctions.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/BaseTestExternalFunctions.java?rev=1902771&r1=1902770&r2=1902771&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/BaseTestExternalFunctions.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/BaseTestExternalFunctions.java Sat Jul 16 10:05:38 2022
@@ -132,8 +132,6 @@ public abstract class BaseTestExternalFu
 
     /**
      * test invoking saved ATP functions
-     *
-     * @param testFile  either atp.xls or atp.xlsx
      */
     @Test
     void baseTestInvokeATP() throws IOException {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org