You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2018/06/01 04:00:24 UTC
[incubator-superset] branch master updated: adding null checks to
adhoc filter popover (#5111)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 40fadfc adding null checks to adhoc filter popover (#5111)
40fadfc is described below
commit 40fadfcb4f7decc364f3f875fcd5723d81145ad8
Author: Gabe Lyons <ga...@airbnb.com>
AuthorDate: Thu May 31 21:00:20 2018 -0700
adding null checks to adhoc filter popover (#5111)
---
.../explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
index bf8fa1d..222772a 100644
--- a/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
+++ b/superset/assets/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx
@@ -141,8 +141,10 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon
handleMultiComparatorInputHeightChange() {
if (this.multiComparatorComponent) {
- // eslint-disable-next-line no-underscore-dangle
- const multiComparatorDOMNode = this.multiComparatorComponent._selectRef.select.control;
+ /* eslint-disable no-underscore-dangle */
+ const multiComparatorDOMNode = this.multiComparatorComponent._selectRef &&
+ this.multiComparatorComponent._selectRef.select &&
+ this.multiComparatorComponent._selectRef.select.control;
if (multiComparatorDOMNode) {
if (multiComparatorDOMNode.clientHeight !== this.state.multiComparatorHeight) {
this.props.onHeightChange((
--
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.