You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2023/03/01 12:41:27 UTC
[skywalking-banyandb] 01/01: Do some chores
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch go1.20
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit b418eff3b09ff0133c2dd8b4266b21b5703f1c93
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Wed Mar 1 12:37:04 2023 +0000
Do some chores
* Bump go to 1.20
* Add a PR template
Signed-off-by: Gao Hongtao <ha...@gmail.com>
---
.github/PULL_REQUEST_TEMPLATE | 23 +++++++++++++++++++++++
.golangci.yml | 6 +++---
.licenserc.yaml | 1 +
CHANGES.md | 6 ++++++
CONTRIBUTING.md | 2 +-
banyand/Dockerfile | 2 +-
bydbctl/Dockerfile | 2 +-
docs/installation.md | 2 +-
go.mod | 2 +-
scripts/build/version.mk | 2 +-
scripts/ci/check/version_test.go | 2 +-
11 files changed, 40 insertions(+), 10 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
new file mode 100644
index 00000000..21ba648f
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -0,0 +1,23 @@
+<!--
+ ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
+ maybe closed without notice.
+ Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
+ Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
+-->
+
+<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
+### Fix <bug description or the bug issue number or bug issue link>
+- [ ] Add a unit test to verify that the fix works.
+- [ ] Explain briefly why the bug exists and how to fix it.
+ ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
+
+<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
+### <Feature description>
+- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
+- [ ] Update the documentation to include this new feature.
+- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
+- [ ] If it's UI related, attach the screenshots below.
+ ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
+
+- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/<issue number>.
+- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
diff --git a/.golangci.yml b/.golangci.yml
index aef9368b..b2ea7995 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -81,7 +81,7 @@ linters-settings:
misspell:
locale: US
unused:
- go: "1.19"
+ go: "1.20"
check-exported: false
unparam:
check-exported: false
@@ -142,10 +142,10 @@ linters-settings:
# all - for all comments.
scope: toplevel
staticcheck:
- go: "1.19"
+ go: "1.20"
checks: ["all", "-ST1000", "-ST1016", "-ST1020", "-ST1021", "-ST1022"]
stylecheck:
- go: "1.19"
+ go: "1.20"
exhaustive:
check:
- switch
diff --git a/.licenserc.yaml b/.licenserc.yaml
index c88b3e93..00e91e4a 100644
--- a/.licenserc.yaml
+++ b/.licenserc.yaml
@@ -83,6 +83,7 @@ header: # `header` section is configurations for source codes license header.
- '**/buf.lock'
- '**/ginkgo.report'
- 'ui'
+ - '.github/PULL_REQUEST_TEMPLATE'
comment: on-failure # on what condition license-eye will comment on the pull request, `on-failure`, `always`, `never`.
diff --git a/CHANGES.md b/CHANGES.md
index 065b1926..e5014c56 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -2,6 +2,12 @@
Release Notes.
+## 0.4.0
+
+### Chores
+
+- Bump go to 1.20.
+
## 0.3.1
### Bugs
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index f62cb2af..72a3e75a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -41,7 +41,7 @@ Once we've discussed your changes and you've got your code ready, make sure that
Users who want to build a binary from sources have to set up:
-* Go 1.19
+* Go 1.20
* Node 16.15
* Git >= 2.30
* Linux, macOS or Windows+WSL2
diff --git a/banyand/Dockerfile b/banyand/Dockerfile
index a3a0ae7d..72cdbbcd 100644
--- a/banyand/Dockerfile
+++ b/banyand/Dockerfile
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.19 AS dev
+FROM golang:1.20 AS dev
WORKDIR /app
ENV GOOS="linux"
ENV CGO_ENABLED=0
diff --git a/bydbctl/Dockerfile b/bydbctl/Dockerfile
index 886eda61..3270ae15 100644
--- a/bydbctl/Dockerfile
+++ b/bydbctl/Dockerfile
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.19 AS base
+FROM golang:1.20 AS base
ENV GOPATH "/go"
ENV GO111MODULE "on"
diff --git a/docs/installation.md b/docs/installation.md
index c81204ec..d7d429f0 100644
--- a/docs/installation.md
+++ b/docs/installation.md
@@ -15,7 +15,7 @@ Get binaries from the [download](https://skywalking.apache.org/downloads/).
Users who want to build a binary from sources have to set up:
-* Go 1.19
+* Go 1.20
* Node 16.15
* Git >= 2.30
* Linux, macOS or Windows+WSL2
diff --git a/go.mod b/go.mod
index 69414c19..aba7feed 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
module github.com/apache/skywalking-banyandb
-go 1.19
+go 1.20
require (
github.com/RoaringBitmap/roaring v0.9.4
diff --git a/scripts/build/version.mk b/scripts/build/version.mk
index e61d6c04..9518619c 100644
--- a/scripts/build/version.mk
+++ b/scripts/build/version.mk
@@ -23,7 +23,7 @@ PROTOC_GEN_DOC_VERSION := v1.5.1
GRPC_GATEWAY_VERSION := v2.10.3
PROTOC_GEN_VALIDATE_VERSION := v0.6.7
-GOLANGCI_LINT_VERSION := v1.50.0
+GOLANGCI_LINT_VERSION := v1.51.2
REVIVE_VERSION := v1.2.4
LICENSE_EYE_VERSION := f461a46e74e5fa22e9f9599a355ab4f0ac265469
diff --git a/scripts/ci/check/version_test.go b/scripts/ci/check/version_test.go
index 11df4931..b02ac05b 100644
--- a/scripts/ci/check/version_test.go
+++ b/scripts/ci/check/version_test.go
@@ -28,7 +28,7 @@ import (
"golang.org/x/mod/modfile"
)
-const GoVersion = "1.19"
+const GoVersion = "1.20"
func TestGoVersion(t *testing.T) {
goversion, err := exec.Command("go", "version").Output()