You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by jm...@apache.org on 2017/12/28 00:47:42 UTC

[incubator-plc4x] 04/19: clean up tests

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git

commit bdaa5fb8c4bb9ead5ecfc96752dc1bb07478d0f0
Author: Justin Mclean <jm...@apache.org>
AuthorDate: Thu Dec 28 08:04:23 2017 +1100

    clean up tests
---
 .../apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java   | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java
index 3f53188..ad273d8 100644
--- a/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java
+++ b/plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/isotp/netty/model/tpdus/IsotpModelTests.java
@@ -58,8 +58,7 @@ class IsotpModelTests {
     @Test
     @Tag("Fast")
     void dataTpdu() {
-        short destinationReference = 0x1;
-               List<Parameter> parameters = Collections.emptyList();
+        List<Parameter> parameters = Collections.emptyList();
         ByteBuf userData = Unpooled.buffer();
 
         userData.writeByte(0x66);
@@ -67,7 +66,7 @@ class IsotpModelTests {
         DataTpdu tpdu = new DataTpdu(true, (byte) 0x7F, parameters, userData);
 
         assertTrue(tpdu.getTpduCode() == TpduCode.DATA);
-        assertTrue(tpdu.isEot() == true, "Unexpected eot reference");
+        assertTrue(tpdu.isEot(), "Unexpected eot reference");
         assertTrue(tpdu.getTpduRef() == 0x7F);
         assertTrue(tpdu.getParameters().isEmpty(), "Unexpected parameters");
         assertTrue(tpdu.getUserData().readByte() == (byte) 0x66, "Unexpected user data");

-- 
To stop receiving notification emails like this one, please contact
"commits@plc4x.apache.org" <co...@plc4x.apache.org>.