You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/04/17 12:23:00 UTC
[PR] [MWRAPPER-103] Apply recommended workaround [maven-wrapper]
cstamas opened a new pull request, #132:
URL: https://github.com/apache/maven-wrapper/pull/132
As Marcono1234 on JIRA issue recommended, added workaround just before the use of `Get-FileHash` call.
---
https://issues.apache.org/jira/browse/MWRAPPER-103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-103] Apply recommended workaround [maven-wrapper]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #132:
URL: https://github.com/apache/maven-wrapper/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-103] Apply recommended workaround [maven-wrapper]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #132:
URL: https://github.com/apache/maven-wrapper/pull/132#issuecomment-2061147476
Unsure is thie import module needed for other use of Get-FileHash as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-103] Apply recommended workaround [maven-wrapper]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #132:
URL: https://github.com/apache/maven-wrapper/pull/132#discussion_r1568771457
##########
maven-wrapper-distribution/src/resources/mvnw.cmd:
##########
@@ -160,6 +160,7 @@ FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapp
)
IF NOT %WRAPPER_SHA_256_SUM%=="" (
powershell -Command "&{"^
+ "Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash"^
Review Comment:
Hm, no idea, but Google found me this: https://poshcode.gitbook.io/powershell-practice-and-style/style-guide/code-layout-and-formatting#avoid-using-semicolons-as-line-terminators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-103] Apply recommended workaround [maven-wrapper]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #132:
URL: https://github.com/apache/maven-wrapper/pull/132#discussion_r1568774598
##########
maven-wrapper-distribution/src/resources/mvnw.cmd:
##########
@@ -160,6 +160,7 @@ FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapp
)
IF NOT %WRAPPER_SHA_256_SUM%=="" (
powershell -Command "&{"^
+ "Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash"^
Review Comment:
even if it is to avoid, will add to be consistent with existing PS code....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-103] Apply recommended workaround [maven-wrapper]
Posted by "jorsol (via GitHub)" <gi...@apache.org>.
jorsol commented on code in PR #132:
URL: https://github.com/apache/maven-wrapper/pull/132#discussion_r1568764174
##########
maven-wrapper-distribution/src/resources/mvnw.cmd:
##########
@@ -160,6 +160,7 @@ FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapp
)
IF NOT %WRAPPER_SHA_256_SUM%=="" (
powershell -Command "&{"^
+ "Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash"^
Review Comment:
I assume that a `;` is needed at the end of Get-FileHash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org