You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/25 23:56:03 UTC
Review Request 38775: Removed unnecessary close calls on ifstream and
ofstream.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38775/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
std::ifstream and std::ofstream have RAII semantics and will close() upon destruction.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp e154bb6a644645e0729d204a645ce93116daa1a5
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 66ece4d08f5c5ff5abb2bc4c52a76aa881390448
Diff: https://reviews.apache.org/r/38775/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38775: Removed unnecessary close calls on ifstream
and ofstream.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38775/#review100698
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 25, 2015, 9:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38775/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:56 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> std::ifstream and std::ofstream have RAII semantics and will close() upon destruction.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp e154bb6a644645e0729d204a645ce93116daa1a5
> 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 66ece4d08f5c5ff5abb2bc4c52a76aa881390448
>
> Diff: https://reviews.apache.org/r/38775/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>