You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mayurvaid-redvest (via GitHub)" <gi...@apache.org> on 2023/03/07 04:07:46 UTC
[GitHub] [camel] mayurvaid-redvest opened a new pull request, #9471: deliveryTag -> For manual ack
mayurvaid-redvest opened a new pull request, #9471:
URL: https://github.com/apache/camel/pull/9471
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mayurvaid-redvest commented on pull request #9471: deliveryTag -> For manual ack
Posted by "mayurvaid-redvest (via GitHub)" <gi...@apache.org>.
mayurvaid-redvest commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1466368777
Thanks @davsclaus / @oscerd , Are we good to merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9471: deliveryTag -> For manual ack
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9471:
URL: https://github.com/apache/camel/pull/9471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9471: deliveryTag -> For manual ack
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1464856385
any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9471: deliveryTag -> For manual ack
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1465902187
I wonder if the delivery tag only make sense to have as a header if ack mode is manual? Are there situations where you need this information elsewhere ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mayurvaid-redvest commented on pull request #9471: deliveryTag -> For manual ack
Posted by "mayurvaid-redvest (via GitHub)" <gi...@apache.org>.
mayurvaid-redvest commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1465931388
> I wonder if the delivery tag only make sense to have as a header if ack mode is manual? Are there situations where you need this information elsewhere ?
Yes Even i am not aware of scenario where we would need this , But having and header would anyways help and gives flexibility to opt for it or not , What are your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9471: deliveryTag -> For manual ack
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1459914163
Are you able to update the docs (see src/main/docs) about this delivery tag and how to do a manual commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9471: deliveryTag -> For manual ack
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1465569267
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9471: deliveryTag -> For manual ack
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1466439372
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mayurvaid-redvest commented on pull request #9471: deliveryTag -> For manual ack
Posted by "mayurvaid-redvest (via GitHub)" <gi...@apache.org>.
mayurvaid-redvest commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1459923261
> Are you able to update the docs (see src/main/docs) about this delivery tag and how to do a manual ack
Thanks for reviewing , Will add this documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9471: deliveryTag -> For manual ack
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1457493567
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9471: deliveryTag -> For manual ack
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1457947263
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9471: deliveryTag -> For manual ack
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1457595921
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9471: deliveryTag -> For manual ack
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1459919756
> I think deliveryTag String should be declared in the Constants class.
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mayurvaid-redvest commented on pull request #9471: deliveryTag -> For manual ack
Posted by "mayurvaid-redvest (via GitHub)" <gi...@apache.org>.
mayurvaid-redvest commented on PR #9471:
URL: https://github.com/apache/camel/pull/9471#issuecomment-1465482564
> any update?
Updated the docs and added constant as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org