You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/24 21:44:04 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `84.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.57% 61.13% -0.45%
==========================================
Files 815 816 +1
Lines 38337 38446 +109
Branches 3599 3612 +13
==========================================
- Hits 23606 23503 -103
- Misses 14545 14757 +212
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.79% <84.44%> (+0.02%)` | :arrow_up: |
| #python | `60.74% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (+0.07%)` | :arrow_up: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `86.00% <83.72%> (-14.00%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `79.16% <0.00%> (-13.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `76.00% <0.00%> (-9.00%)` | :arrow_down: |
| [superset/queries/saved\_queries/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2ZpbHRlcnMucHk=) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `54.92% <0.00%> (-4.17%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [e4e78b6...fed8e1c](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org