You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/16 14:21:52 UTC
[GitHub] [superset] aehanno opened a new pull request, #20080: fix : translating variables
aehanno opened a new pull request, #20080:
URL: https://github.com/apache/superset/pull/20080
### SUMMARY
translating variables
### ADDITIONAL INFORMATION
Fixes https://github.com/apache/superset/issues/20060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20080: fix : translating variables
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1156157434
# [Codecov](https://codecov.io/gh/apache/superset/pull/20080?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20080](https://codecov.io/gh/apache/superset/pull/20080?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08ab7a7) into [master](https://codecov.io/gh/apache/superset/commit/523bd8b79cfd48d1cb3a94f89c8095976844ce59?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (523bd8b) will **decrease** coverage by `0.19%`.
> The diff coverage is `55.74%`.
> :exclamation: Current head 08ab7a7 differs from pull request most recent head 320ce63. Consider uploading reports for the commit 320ce63 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20080 +/- ##
==========================================
- Coverage 66.55% 66.36% -0.20%
==========================================
Files 1692 1715 +23
Lines 64802 64219 -583
Branches 6657 6775 +118
==========================================
- Hits 43129 42617 -512
+ Misses 19973 19879 -94
- Partials 1700 1723 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.31% <55.74%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-chart-controls/src/sections/advancedAnalytics.tsx](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2FkdmFuY2VkQW5hbHl0aWNzLnRzeA==) | `14.28% <0.00%> (-19.05%)` | :arrow_down: |
| [...d/packages/superset-ui-chart-controls/src/types.ts](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...perset-ui-core/src/chart/components/SuperChart.tsx](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvY29tcG9uZW50cy9TdXBlckNoYXJ0LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ugins/legacy-plugin-chart-calendar/src/Calendar.js](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNhbGVuZGFyL3NyYy9DYWxlbmRhci5qcw==) | `0.00% <ø> (ø)` | |
| [...legacy-plugin-chart-calendar/src/ReactCalendar.jsx](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNhbGVuZGFyL3NyYy9SZWFjdENhbGVuZGFyLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL2NvbnRyb2xQYW5lbC50cw==) | `66.66% <ø> (ø)` | |
| [.../legacy-plugin-chart-histogram/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvY29udHJvbFBhbmVsLnRz) | `60.00% <ø> (ø)` | |
| [...egacy-plugin-chart-world-map/src/ReactWorldMap.jsx](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvUmVhY3RXb3JsZE1hcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...gins/legacy-plugin-chart-world-map/src/WorldMap.js](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvV29ybGRNYXAuanM=) | `0.00% <ø> (ø)` | |
| [...acy-preset-chart-deckgl/src/components/Tooltip.tsx](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvY29tcG9uZW50cy9Ub29sdGlwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [226 more](https://codecov.io/gh/apache/superset/pull/20080/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20080?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20080?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [523bd8b...320ce63](https://codecov.io/gh/apache/superset/pull/20080?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1936546611
Sadly, it looks like this never passed, CI, never got validation of the translated strings, and now is in need of a rebase again. @aehanno would you mind doing a rebase, and we can try again to get this across the finish line? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1486502521
##########
superset-frontend/src/dashboard/components/FiltersBadge/FilterIndicator/index.tsx:
##########
@@ -51,7 +52,7 @@ const FilterIndicator: FC<IndicatorProps> = ({
{name}
{resultValue ? ': ' : ''}
</Title>
- <FilterValue>{resultValue}</FilterValue>
+ <FilterValue>{t(resultValue)}</FilterValue>
Review Comment:
Hey in my understanding of the translation framework, it does static analysis of the code to find translatable strings, it only works on constants not on variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1486505235
##########
superset/translations/fr/LC_MESSAGES/messages.json:
##########
@@ -3877,7 +3877,27 @@
],
"Scope": ["Périmètre"],
"Dependent on": ["Dépend de"],
- "No matching records found": ["Aucun résultat trouvé"]
+ "No matching records found": ["Aucun résultat trouvé"],
Review Comment:
isn't the `.json` file generated here? shouldn't this be in the `.po` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1486503460
##########
superset/translations/fr/LC_MESSAGES/messages.json:
##########
@@ -3877,7 +3877,27 @@
],
"Scope": ["Périmètre"],
"Dependent on": ["Dépend de"],
- "No matching records found": ["Aucun résultat trouvé"]
+ "No matching records found": ["Aucun résultat trouvé"],
+ "Trend": ["Tendance"],
+ "Total (Count)": ["Total (Somme)"],
Review Comment:
Count != Somme
more like "Compte" ou "Nombre"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-2455317142
Looks like the comments on the PR were never addressed, and now it's in need of a rebase. I'll go ahead and convert this to draft. If you want to bring it back up to a mergeable state, that would be fantastic, but if not, we'll close this eventually. Thanks in any case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on pull request #20080: fix : translating variables
Posted by GitBox <gi...@apache.org>.
aehanno commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1147608166
@villebro , i will be glad to discuss with you about variable translation.
Without adding translation on those varaibles, we have any translation on the second part of those sentence
I only find this solution and after testing, I didn't catch error with this correction
I understand your worries about that, and i will be glad to understand any other solution to solve that problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #20080: fix: translating variables
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1409553871
Looks like this needs a rebase. There have been some other PRs recently adding translations as well, so I hope it's not too painful.
We also still need some validation of the language itself, if @mistercrunch or anyone else that speaks French has time to scope it out :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #20080: fix : translating variables
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1156115696
@aehanno can you show a before and after of these changes? I'd like to understand how these translations are being picked up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #20080: fix: translating variables
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1042783748
##########
superset-frontend/src/dashboard/components/FiltersBadge/FilterIndicator/index.tsx:
##########
@@ -51,7 +52,7 @@ const FilterIndicator: FC<IndicatorProps> = ({
{name}
{resultValue ? ': ' : ''}
</Title>
- <FilterValue>{resultValue}</FilterValue>
+ <FilterValue>{t(resultValue)}</FilterValue>
Review Comment:
This seems like something that might not have a static/expected value, is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #20080: fix: translating variables
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1043919196
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
<Divider />
<div>
<div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}
Review Comment:
Maybe it's worth putting a little ternary condition or similar in there, e.g. `evalResponse = 'no filter' ? t('no filter') : evalResponse`? Or maybe there's somewhere further upstream in the code that's more appropriate to the the translation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1486513159
##########
superset/translations/fr/LC_MESSAGES/messages.json:
##########
@@ -3877,7 +3877,27 @@
],
"Scope": ["Périmètre"],
"Dependent on": ["Dépend de"],
- "No matching records found": ["Aucun résultat trouvé"]
+ "No matching records found": ["Aucun résultat trouvé"],
Review Comment:
Yes indeed! I thought that was covered in this PR, but that doesn't seem to be the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #20080: fix: translating variables
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1042784456
##########
superset/translations/fr/LC_MESSAGES/messages.json:
##########
@@ -3877,7 +3877,27 @@
],
"Scope": ["Périmètre"],
"Dependent on": ["Dépend de"],
- "No matching records found": ["Aucun résultat trouvé"]
+ "No matching records found": ["Aucun résultat trouvé"],
+ "Trend": ["Tendance"],
+ "Total (Count)": ["Total (Somme)"],
+ "Total (%s)": ["Total (%s)"],
+ "Total (Count Unique Values)": ["Total (Somme)"],
+ "Total (List Unique Values)": ["Total (Somme)"],
+ "Sum": ["Somme"],
+ "Average": ["Moyenne"],
+ "Median": ["Médiane"],
+ "Sample Variance": ["Variance échantillon"],
+ "Sample Standard Deviation": ["Écart-type échantillon"],
+ "Minimum": ["Minimum"],
+ "Maximum": ["Maximum"],
+ "First": ["Premier"],
+ "Last": ["Dernier"],
+ "Sum as Fraction of Total": ["Somme comme fraction du total"],
+ "Sum as Fraction of Rows": ["Somme comme fraction des lignes"],
+ "Sum as Fraction of Columns": ["Somme comme fraction des colonnes"],
+ "Count as Fraction of Total": ["Décompte comme fraction du total"],
+ "Count as Fraction of Rows": ["Décompte comme fraction des lignes"],
+ "Count as Fraction of Columns": ["Décompte comme fraction des colonnes"]
Review Comment:
@mistercrunch do the above translations look correct to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #20080: fix: translating variables
URL: https://github.com/apache/superset/pull/20080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on pull request #20080: fix : translating variables
Posted by GitBox <gi...@apache.org>.
aehanno commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1156500202
> @aehanno can you show a before and after of these changes? I'd like to understand how these translations are being picked up
Hey @villebro, yes of course, I can show you an exemple.
It's in dashboard edition in charts tab.
For this one, I added modification in SliceAdder.jsx file,
There is before my correction `label: t('Sort by %s', label),`
And this one is after my correction `label: t('Sort by %s', t(label)),`
We can see the second part is well translate in the second image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: translating variables [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-2741792501
This has sat untouched in draft mode for quite a while, so we'll go ahead and close it. We welcome you to reopen it if you want to contribute the change. Thank you for your contribution nonetheless!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on a diff in pull request #20080: fix: translating variables
Posted by GitBox <gi...@apache.org>.
aehanno commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1042798093
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
<Divider />
<div>
<div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}
Review Comment:
Yes, it's a date or it's write 'No filter', so I think in fact that will juste translate 'no filter' and don't touch to other result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #20080: fix: translating variables
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #20080:
URL: https://github.com/apache/superset/pull/20080#discussion_r1042784129
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
<Divider />
<div>
<div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}
Review Comment:
Same here... is this something we would expect to have in the translation files, or is it a more dynamic value (as it sounds, based on the name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org