[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3420: Spark: Enforce the netty buffer version to fix jmh test failures in Spark 3.2

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #3420:
URL: https://github.com/apache/iceberg/pull/3420#discussion_r740476989



##########
File path: build.gradle
##########
@@ -489,8 +489,11 @@ project(':iceberg-arrow') {
     implementation("org.apache.arrow:arrow-memory-netty") {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
       exclude group: 'io.netty', module: 'netty-common'
+      exclude group: 'io.netty', module: 'netty-buffer'
     }
 
+    runtimeOnly("io.netty:netty-buffer")

Review comment:
       Just for my understanding. We do need this dep for our Arrow implementation at runtime.
   Previously, it came from `arrow-memory-netty` and was shaded in the Spark runtime jar. As far as I see, we kept the shading but also excluded `netty-buffer` from the arrow dependency. What do we shade now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org