You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2026/09/21 07:36:25 UTC

[PR] Support Oracle drop unused columns syntax [shardingsphere]

FlyingZC opened a new pull request, #39917:
URL: https://github.com/apache/shardingsphere/pull/39917

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   - [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
   
   [AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support Oracle drop unused columns syntax [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #39917:
URL: https://github.com/apache/shardingsphere/pull/39917


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support Oracle drop unused columns syntax [shardingsphere]

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on PR #39917:
URL: https://github.com/apache/shardingsphere/pull/39917#issuecomment-5757024450

    ### Result
   
     **Review Result: Mergeable**
   
     The candidate adds the documented Oracle syntax at the dialect parser owner, preserves existing named-column semantics, and introduces paired parser cases without
     changing public contracts.
   
     ### Evidence
   
     - Oracle 19c SQL Reference confirms `DROP UNUSED COLUMNS [CHECKPOINT [integer]]`.
     - Oracle parser owner reactor completed successfully.
     - InternalOracleParserIT passed 1967 tests with no failures or errors.
     - Exact candidate Spotless and Checkstyle checks passed.
     - XML resources are valid and each SQL case has one matching expected case.
   
     ### Coverage
   
     - Standalone local candidate based on `apache/master@7e2dae148026f83b0108b0b1c9ae085c41dae4de`.
     - Reviewed commit: `d80a2c977e82946004f7e8af3fea85fa198d7033`.
     - Reviewed one Oracle G4 file, one Oracle visitor, and two Parser IT resource files.
     - Target dialect: Oracle; no repository-defined branch dialect requires synchronization.
     - Full repository verification was explicitly waived.
     - Code-correctness review only; GitHub CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org