You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hmcl <gi...@git.apache.org> on 2016/12/17 10:25:54 UTC
[GitHub] storm pull request #1831: STORM-2249: Make Distribution Scripts Put Examples...
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1831
STORM-2249: Make Distribution Scripts Put Examples to the Correct Locations
- Move all examples under STORM_HOME/examples/storm-COMPONENT-NAME-examples/COMPONENT-NAME-examples-x.y.x.jar
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache Apache_master_STORM-2249_Fix_Dist_Examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1831
----
commit 2787d7ef2e904e06600484dc5d1857ba41e2d96c
Author: Hugo Louro <hm...@gmail.com>
Date: 2016-12-17T10:01:12Z
STORM-2249: Make Distribution Scripts Put Examples to the Correct Locations
- Move all examples under STORM_HOME/examples/storm-COMPONENT-NAME-examples/COMPONENT-NAME-examples-x.y.x.jar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
The change looks great, but we need to think why shaded jar of examples are necessary to be included to binary distribution.
AFAIK the examples modules (except storm-starter) are for referring the working example source code rather than executing the topology. Do we expect end-user would run the example topology? If we expect, we should document about topologies to README.md for each modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@harshach @hmcl
Then we should add available topologies in README for each modules to since users don't know which topologies are available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
Before:
-rw-r--r-- 1 jlim staff 3.3K 3 2 19:41 apache-storm-2.0.0-SNAPSHOT.pom
-rw-r--r-- 1 jlim staff 473B 3 2 19:41 apache-storm-2.0.0-SNAPSHOT.pom.asc
-rw-r--r-- 1 jlim staff 264M 3 2 19:41 apache-storm-2.0.0-SNAPSHOT.tar.gz
-rw-r--r-- 1 jlim staff 473B 3 2 19:41 apache-storm-2.0.0-SNAPSHOT.tar.gz.asc
-rw-r--r-- 1 jlim staff 264M 3 2 19:41 apache-storm-2.0.0-SNAPSHOT.zip
-rw-r--r-- 1 jlim staff 473B 3 2 19:41 apache-storm-2.0.0-SNAPSHOT.zip.asc
----------
After:
-rw-r--r-- 1 jlim staff 3.3K 3 2 19:46 apache-storm-2.0.0-SNAPSHOT.pom
-rw-r--r-- 1 jlim staff 473B 3 2 19:46 apache-storm-2.0.0-SNAPSHOT.pom.asc
-rw-r--r-- 1 jlim staff 564M 3 2 19:46 apache-storm-2.0.0-SNAPSHOT.tar.gz
-rw-r--r-- 1 jlim staff 473B 3 2 19:46 apache-storm-2.0.0-SNAPSHOT.tar.gz.asc
-rw-r--r-- 1 jlim staff 565M 3 2 19:46 apache-storm-2.0.0-SNAPSHOT.zip
-rw-r--r-- 1 jlim staff 473B 3 2 19:47 apache-storm-2.0.0-SNAPSHOT.zip.asc
Sorry but for me the final size (exceeding 500M) is hard to accept. Could we re-think about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
We applied opposite approach for this. Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1831
Whit these changes the examples distribution looks like this:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1831: STORM-2249: Make Distribution Scripts Put Examples...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/1831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
Right. But I changed my mind that all examples should contain the code, like storm-starter in binary dist. We're extracting examples to show example **codes** for each modules, so the most important thing is code.
@harshach What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
Also could you check how big binary dist (tar.gz / zip) will be? It's already over 200MB so IMHO it would be better to reduce/restrict the size of binary dist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1831
@HeartSaVioR do you mean each README of each module should have a section on how to run the JAR, and the main for that JAR? I agree with that. Perhaps I could file a follow-up JIRA for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1831: STORM-2249: Make Distribution Scripts Put Examples to the...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1831
@HeartSaVioR I think it makes sense to have the shaded jars. It will be easier to run the code for the users who not familiar with storm packaging and gives insight into building a topology jar as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---