You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/03/31 22:30:36 UTC
Review Request 32700: Removed FrameworkID from FrameworkState.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/
-----------------------------------------------------------
Review request for mesos, Adam B and Niklas Nielsen.
Bugs: MESOS-2559
https://issues.apache.org/jira/browse/MESOS-2559
Repository: mesos
Description
-------
FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
Diffs
-----
src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97
src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9
src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02
src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/32700/diff/
Testing
-------
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review78579
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32583, 32584, 32585, 32586, 32587, 32700]
All tests passed.
- Mesos ReviewBot
On April 1, 2015, 7:35 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 7:35 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Bugs: MESOS-2559
> https://issues.apache.org/jira/browse/MESOS-2559
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97
> src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9
> src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
> src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
> src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02
> src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
> TODO: Test for upgrade path.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Adam B <ad...@mesosphere.io>.
> On Aug. 3, 2015, 6:41 p.m., Adam B wrote:
> > Looks great! Just a couple of questions.
> > Did you run `sudo make check`, since you modified `ROOT_` tests?
@karya, should we revive this patch now, or discard it?
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review93988
-----------------------------------------------------------
On Aug. 1, 2015, 12:13 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 12:13 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-905
> https://issues.apache.org/jira/browse/MESOS-905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b
> src/slave/containerizer/external_containerizer.cpp d3640e7beaa7a99d7c8938025af879e19cd6b470
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
> src/slave/status_update_manager.cpp 1978ac8ab370f3e20f5c3c803beda468edf31e2c
> src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40
> src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef11116b52497eb32d539
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review93988
-----------------------------------------------------------
Looks great! Just a couple of questions.
Did you run `sudo make check`, since you modified `ROOT_` tests?
src/slave/status_update_manager.cpp (lines 209 - 210)
<https://reviews.apache.org/r/32700/#comment148472>
I don't understand this check. A framework without executors will not have a FrameworkInfo? Then why did we even store/recover a FrameworkState? Is this some other upgrade issue?
Is a CHECK too strong of an error check?
Ditto elsewhere.
- Adam B
On Aug. 1, 2015, 12:13 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 12:13 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-905
> https://issues.apache.org/jira/browse/MESOS-905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b
> src/slave/containerizer/external_containerizer.cpp d3640e7beaa7a99d7c8938025af879e19cd6b470
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
> src/slave/status_update_manager.cpp 1978ac8ab370f3e20f5c3c803beda468edf31e2c
> src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40
> src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef11116b52497eb32d539
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review93847
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32700]
All tests passed.
- Mesos ReviewBot
On Aug. 1, 2015, 7:13 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 7:13 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-905
> https://issues.apache.org/jira/browse/MESOS-905
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b
> src/slave/containerizer/external_containerizer.cpp d3640e7beaa7a99d7c8938025af879e19cd6b470
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
> src/slave/status_update_manager.cpp 1978ac8ab370f3e20f5c3c803beda468edf31e2c
> src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40
> src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef11116b52497eb32d539
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/
-----------------------------------------------------------
(Updated Aug. 1, 2015, 3:13 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-905
https://issues.apache.org/jira/browse/MESOS-905
Repository: mesos
Description
-------
FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 8f5d302477b216df9ac2f59156304bbc4a96f24b
src/slave/containerizer/external_containerizer.cpp d3640e7beaa7a99d7c8938025af879e19cd6b470
src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
src/slave/status_update_manager.cpp 1978ac8ab370f3e20f5c3c803beda468edf31e2c
src/tests/containerizer/docker_containerizer_tests.cpp 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40
src/tests/containerizer/mesos_containerizer_tests.cpp 213fa4b0b9c50eba941ef11116b52497eb32d539
Diff: https://reviews.apache.org/r/32700/diff/
Testing (updated)
-------
make check.
Thanks,
Kapil Arya
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review79215
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32583, 32584, 32585, 32586, 32587, 32700]
All tests passed.
- Mesos ReviewBot
On April 7, 2015, 5 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 5 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Bugs: MESOS-2559
> https://issues.apache.org/jira/browse/MESOS-2559
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97
> src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9
> src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
> src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
> src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02
> src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
> TODO: Test for upgrade path.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/
-----------------------------------------------------------
(Updated April 7, 2015, 1 p.m.)
Review request for mesos, Adam B and Niklas Nielsen.
Changes
-------
rebased
Bugs: MESOS-2559
https://issues.apache.org/jira/browse/MESOS-2559
Repository: mesos
Description
-------
FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97
src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9
src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02
src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/32700/diff/
Testing
-------
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/
-----------------------------------------------------------
(Updated April 1, 2015, 3:35 p.m.)
Review request for mesos, Adam B and Niklas Nielsen.
Changes
-------
rebased
Bugs: MESOS-2559
https://issues.apache.org/jira/browse/MESOS-2559
Repository: mesos
Description
-------
FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
Diffs (updated)
-----
src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97
src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9
src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02
src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/32700/diff/
Testing
-------
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review78438
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32583, 32584, 32585, 32586, 32587, 32700]
All tests passed.
- Mesos ReviewBot
On March 31, 2015, 8:30 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32700/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 8:30 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Bugs: MESOS-2559
> https://issues.apache.org/jira/browse/MESOS-2559
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FrameworkState already has FrameworkInfo which will have a valid FrameworkID.
>
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97
> src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9
> src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
> src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
> src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02
> src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/32700/diff/
>
>
> Testing
> -------
>
> make check.
>
> TODO: Test for upgrade path.
>
>
> Thanks,
>
> Kapil Arya
>
>