[jira] [Commented] (YARN-252) Unmanaged AMs should not have to set the ContainerLaunchContext

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507883#comment-13507883 ] 

Bikas Saha commented on YARN-252:
---------------------------------

I had initially done this for MAPREDUCE-4438 but later changed it back to an empty object since I wasnt sure if more code in the RM could end up trying to access the context without checking for it being non-null (and causing the RM to crash).
I also wasnt sure if a context object would be needed or not in order to implement YARN-255.
Is there a specific issue thats requires removal of the code from the client and addition of existence checks in the RM?

In any case, maybe we should also assert that context is null because the am is unmanaged. Otherwise we might end up ignoring future bugs in the RM when the context should not be null but happens to be so (100% of managed AM's currently).
                
> Unmanaged AMs should not have to set the ContainerLaunchContext
> ---------------------------------------------------------------
>
>                 Key: YARN-252
>                 URL: https://issues.apache.org/jira/browse/YARN-252
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>    Affects Versions: 2.0.2-alpha
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: YARN-252.patch
>
>
> Not calling ApplicationSubmissionContext#setAMContainerSpec causes a NPE, even though the container is not used (since the AM doesn't run in a managed YARN container).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira