You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2017/12/27 02:46:33 UTC

[GitHub] wujimin commented on a change in pull request #468: [SCB-126] Add Consumer side event trigger for collect metrics data

wujimin commented on a change in pull request #468: [SCB-126] Add Consumer side event trigger for collect metrics data
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/468#discussion_r158756076
 
 

 ##########
 File path: transports/transport-highway/src/main/java/io/servicecomb/transport/highway/HighwayClient.java
 ##########
 @@ -100,22 +105,26 @@ public void send(Invocation invocation, AsyncResponse asyncResp) throws Exceptio
     tcpClientPool.send(tcpClient, clientPackage, ar -> {
 
 Review comment:
   we can add a metric item to show net time.
   if too complex,  create a new issue for it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services