[GitHub] [dubbo] AlbumenJ commented on a change in pull request #9211: [3.0] allocate space for invokers and validInvokers to avoid NPE

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #9211:
URL: https://github.com/apache/dubbo/pull/9211#discussion_r744082761



##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/MultiInstanceTest.java
##########
@@ -845,9 +845,10 @@ public void testAsyncExportAndReferServices() throws ExecutionException, Interru
             logger.warn("consumer app is startup");
             Object target = referenceConfig.getServiceMetadata().getTarget();
             Assertions.assertNotNull(target);
-            Greeting greetingService = (Greeting) target;
-            String result = greetingService.hello();
-            Assertions.assertEquals("local", result);
+            // provider app started != provider app registered
+//            Greeting greetingService = (Greeting) target;
+//            String result = greetingService.hello();
+//            Assertions.assertEquals("local", result);

Review comment:
       We need to take other actions, such as waiting for the provider app to register, to ensure that this test is feasible




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org