[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5014: [ISSUE #5013] allow broker to bind specified network interface

[GitBox <gi...@apache.org>]

lizhanhui commented on code in PR #5014:
URL: https://github.com/apache/rocketmq/pull/5014#discussion_r964447708


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java:
##########
@@ -139,6 +138,12 @@ public static BrokerController createBrokerController(String[] args) {
                 System.exit(-2);
             }
 
+            if (!nettyServerConfig.getBindIP().equals("0.0.0.0") &&
+                !nettyServerConfig.getBindIP().equals(brokerConfig.getBrokerIP1())) {

Review Comment:
   The host to bind may be different with wildcard address and broker IP1. Broker IP1 is for clients to connect to brokers. For example, in the cloud environment, brokerIP1 is configured to its public IP. 
   The ECS itself may have multiple network interfaces wiring virtually to different networks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org