You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/08/10 06:38:11 UTC
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16317
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
[monotime] add MonoDelta::operator{+,-}()
Added a bit of syntactic sugar: MonoDelta::operator+() and
MonoDelta::operator-() and corresponding test scenarios.
I'm going to use these new operators in a follow-up changelist.
Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
---
M src/kudu/util/monotime-test.cc
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
3 files changed, 70 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16317/1
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16317 )
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
[monotime] add MonoDelta::operator{+,-}()
Added a bit of syntactic sugar: MonoDelta::operator+() and
MonoDelta::operator-() and corresponding test scenarios.
I'm going to use these new operators in a follow-up changelist.
Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Reviewed-on: http://gerrit.cloudera.org:8080/16317
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/util/monotime-test.cc
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
3 files changed, 73 insertions(+), 7 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16317 )
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
Patch Set 2: Verified+1
LSAN issue is one we've seen, probably unrelated to this patch:
=================================================================
==24521==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4368 byte(s) in 2 object(s) allocated from:
#0 0x55d601 in malloc /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:145
#1 0x7f8f7b34adb2 in CRYPTO_malloc (/lib/x86_64-linux-gnu/libcrypto.so.1.0.0+0x5fdb2)
SUMMARY: AddressSanitizer: 4368 byte(s) leaked in 2 allocation(s).
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Aug 2020 22:15:12 +0000
Gerrit-HasComments: No
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16317 )
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
Patch Set 2:
> LSAN issue is one we've seen, probably unrelated to this patch:
>
>
> =================================================================
> ==24521==ERROR: LeakSanitizer: detected memory leaks
>
> Direct leak of 4368 byte(s) in 2 object(s) allocated from:
> #0 0x55d601 in malloc /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:145
> #1 0x7f8f7b34adb2 in CRYPTO_malloc (/lib/x86_64-linux-gnu/libcrypto.so.1.0.0+0x5fdb2)
>
> SUMMARY: AddressSanitizer: 4368 byte(s) leaked in 2 allocation(s).
Thank you for clarifying on these!
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Aug 2020 23:53:11 +0000
Gerrit-HasComments: No
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16317
to look at the new patch set (#2).
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
[monotime] add MonoDelta::operator{+,-}()
Added a bit of syntactic sugar: MonoDelta::operator+() and
MonoDelta::operator-() and corresponding test scenarios.
I'm going to use these new operators in a follow-up changelist.
Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
---
M src/kudu/util/monotime-test.cc
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
3 files changed, 73 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16317/2
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16317 )
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16317/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:
http://gerrit.cloudera.org:8080/#/c/16317/1/src/kudu/util/monotime.cc@148
PS1, Line 148: timespec *
nit: stick * to data type
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Aug 2020 16:28:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16317 )
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16317/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:
http://gerrit.cloudera.org:8080/#/c/16317/1/src/kudu/util/monotime.cc@148
PS1, Line 148: timespec *
> nit: stick * to data type
Done
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Aug 2020 16:50:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [monotime] add MonoDelta::operator{+,-}()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16317 )
Change subject: [monotime] add MonoDelta::operator{+,-}()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfad30af72128b4d0054993243bfc00e67b89a9e
Gerrit-Change-Number: 16317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Aug 2020 22:18:01 +0000
Gerrit-HasComments: No