You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/01/10 21:46:54 UTC
Review Request 65078: ATLAS-2351: fixed V1 REST APIs to retain the
format for date type attributes as in earlier versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65078/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-2351
https://issues.apache.org/jira/browse/ATLAS-2351
Repository: atlas
Description
-------
Update V1 REST APIs to serialize the response using AtlasJson.toV1Json(), so that the format will be consistent with earlier version of Atlas
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java c21dff42
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8fd4d5ad
webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java a69b0e73
Diff: https://reviews.apache.org/r/65078/diff/1/
Testing
-------
Verified that entity retrieved using V1 REST API has date type attributes formatted as in earlier versions of Atlas i.e. using format-string "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
Thanks,
Madhan Neethiraj
Re: Review Request 65078: ATLAS-2351: fixed V1 REST APIs to retain the
format for date type attributes as in earlier versions
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65078/#review195201
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 10, 2018, 3:35 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65078/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 3:35 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2351
> https://issues.apache.org/jira/browse/ATLAS-2351
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Update V1 REST APIs to serialize the response using AtlasJson.toV1Json(), so that the format will be consistent with earlier version of Atlas
>
>
> Diffs
> -----
>
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java 05b6cc61
> intg/src/main/java/org/apache/atlas/utils/AtlasJson.java 84234d98
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java c21dff42
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8fd4d5ad
> webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java a69b0e73
>
>
> Diff: https://reviews.apache.org/r/65078/diff/2/
>
>
> Testing
> -------
>
> Verified that entity retrieved using V1 REST API has date type attributes formatted as in earlier versions of Atlas i.e. using format-string "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 65078: ATLAS-2351: fixed V1 REST APIs to retain the
format for date type attributes as in earlier versions
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65078/
-----------------------------------------------------------
(Updated Jan. 10, 2018, 11:35 p.m.)
Review request for atlas.
Changes
-------
updated the patch to address issues found during import-hive
Bugs: ATLAS-2351
https://issues.apache.org/jira/browse/ATLAS-2351
Repository: atlas
Description
-------
Update V1 REST APIs to serialize the response using AtlasJson.toV1Json(), so that the format will be consistent with earlier version of Atlas
Diffs (updated)
-----
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java 05b6cc61
intg/src/main/java/org/apache/atlas/utils/AtlasJson.java 84234d98
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java c21dff42
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8fd4d5ad
webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java a69b0e73
Diff: https://reviews.apache.org/r/65078/diff/2/
Changes: https://reviews.apache.org/r/65078/diff/1-2/
Testing
-------
Verified that entity retrieved using V1 REST API has date type attributes formatted as in earlier versions of Atlas i.e. using format-string "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
Thanks,
Madhan Neethiraj