You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2017/03/16 07:57:07 UTC
[GitHub] cordova-lib pull request #529: CB-11346 Remove known platforms check
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/529
CB-11346 Remove known platforms check
Building on top of the work by @purplecabbage and @shazron.
Still need to fix failing tests + add some new tests.
Also, need to run through plugin install steps.
work in progress
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-lib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #529
----
commit 3a810d1887bc488e8e9e9dfacdc6e86a80b4b318
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-02-21T01:47:14Z
CB-11346 - Remove known platforms check for Platform API
commit faf54779fd6e02f23d2a302629599e578fd5d02a
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2017-02-28T00:13:43Z
CB-11346: Remove known platforms check
This closes #523, This closes #519
commit 5a5d02898dc3286c8494c5986edf0e5f439d8215
Author: Steve Gill <st...@gmail.com>
Date: 2017-03-11T00:43:56Z
CB-11346: fixed remove platform to work with unknown platforms
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/529
Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #529: CB-11346 Remove known platforms check
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/529
Now to add tests!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/529
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=h1) Report
> Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `92.68%`.
```diff
@@ Coverage Diff @@
## master #529 +/- ##
=========================================
+ Coverage 81.9% 81.9% +<.01%
=========================================
Files 68 68
Lines 5498 5499 +1
Branches 1090 1086 -4
=========================================
+ Hits 4503 4504 +1
Misses 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `93.75% <�> (-0.44%)` | :x: |
| [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `87.07% <�> (-0.09%)` | :x: |
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.2% <100%> (�)` | :white_check_mark: |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
| [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=) | `97.14% <94.73%> (+0.59%)` | :white_check_mark: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=footer). Last update [07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/529
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=h1) Report
> Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `92.68%`.
```diff
@@ Coverage Diff @@
## master #529 +/- ##
=========================================
+ Coverage 81.9% 81.9% +<.01%
=========================================
Files 68 68
Lines 5498 5499 +1
Branches 1090 1086 -4
=========================================
+ Hits 4503 4504 +1
Misses 995 995
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `87.07% <�> (-0.09%)` | :x: |
| [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `93.75% <�> (-0.44%)` | :x: |
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.2% <100%> (�)` | :white_check_mark: |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
| [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=) | `97.14% <94.73%> (+0.59%)` | :white_check_mark: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=footer). Last update [07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/529
Ran npm test and also tested manually with a test project. Was able to add a "non core" platform name, run, and build successfully. No errors to report! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org