[GitHub] [kafka] ijuma commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r746604748



##########
File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceConnectorTest.java
##########
@@ -55,18 +54,14 @@ public void setup() {
 
     @Test
     public void testConnectorConfigValidation() {
-        replayAll();
         List<ConfigValue> configValues = connector.config().validate(sourceProperties);
         for (ConfigValue val : configValues) {
             assertEquals(0, val.errorMessages().size(), "Config property errors: " + val.errorMessages());
         }
-        verifyAll();

Review comment:
       Don't we need any `verify` calls here?

##########
File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##########
@@ -220,6 +222,8 @@ public void testMissingFile() throws InterruptedException {
         task.stop();
     }
 
+    @Test
+    @Disabled

Review comment:
       Why did we disable this test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org