[GitHub] [cordova-plugin-inappbrowser] yesenarman commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased)

[GitBox <gi...@apache.org>]

yesenarman commented on issue #647: feat(android): Ask for file permission when opening a download link (CB-12834) (rebased)
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/647#issuecomment-600836384
 
 
   Thanks. I think I don't have rights to request a review.
   
   > Maybe the Toast message text should be configurable (translatable).
   
   That's a good point.
   
   Should they be configurable via the options string? There are two things that concern me about passing them via options string:
   1. It is also easy to forget to pass these strings every time you need to open IAB. Also the options string might become very long.
   2. The success message has this format currently "Downloading File '{filename}'". So should users be able to configure/translate just the "Downloading File" part or should they be able to specify the whole string formatting, including the {filename} substitution part?
   
   Another option would be to have these strings as Android String resources in `values/strings.xml` and then let users to provide translations by adding appropriate XML file with translated strings (e.g `values-ru/strings.xml`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org