[GitHub] [skywalking] dominicqi opened a new issue #4053: Hystrix plugin throw exception cause HystrixCommand execute failed

[GitBox <gi...@apache.org>]

dominicqi opened a new issue #4053: Hystrix plugin throw exception cause HystrixCommand execute failed
URL: https://github.com/apache/skywalking/issues/4053
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [+] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.
   
   https://github.com/apache/skywalking/blob/fd24a29b3b0451d6a8527beae1ac5d6ff97c8600/apm-sniffer/apm-sdk-plugin/hystrix-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hystrix/v1/SWExecutionHookWrapper.java#L42
   
   The Hystrix plugin use `HystrixCommandExecutionHook` , i think  `SWExecutionHookWrapper` should catch Throwable , not thrown. if the plugin throw a exception , will make hystrix fast-fail with no fallback。 
   This happend in my application. The hook throw a exception 'No active span',then hystrixCommand fail without fallback. I haven't found out why yet ,but i think the plugin should not thrown exception to the apllication . 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services