You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/01 12:44:31 UTC

[GitHub] zentol closed pull request #6973: [hotfix] [docs] fix typos in Elasticsearch6 examples

zentol closed pull request #6973: [hotfix] [docs]  fix typos in Elasticsearch6 examples
URL: https://github.com/apache/flink/pull/6973
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/dev/connectors/elasticsearch.md b/docs/dev/connectors/elasticsearch.md
index 927bb69f1a7..de24149bc75 100644
--- a/docs/dev/connectors/elasticsearch.md
+++ b/docs/dev/connectors/elasticsearch.md
@@ -180,6 +180,7 @@ input.addSink(new ElasticsearchSink<>(config, transportAddresses, new Elasticsea
 {% highlight java %}
 import org.apache.flink.api.common.functions.RuntimeContext;
 import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkFunction;
 import org.apache.flink.streaming.connectors.elasticsearch.RequestIndexer;
 import org.apache.flink.streaming.connectors.elasticsearch6.ElasticsearchSink;
 
@@ -194,7 +195,7 @@ import java.util.Map;
 
 DataStream<String> input = ...;
 
-List<HttpHost> httpHost = new ArrayList<>();
+List<HttpHost> httpHosts = new ArrayList<>();
 httpHosts.add(new HttpHost("127.0.0.1", 9200, "http"));
 httpHosts.add(new HttpHost("10.2.3.1", 9200, "http"));
 
@@ -220,10 +221,10 @@ ElasticsearchSink.Builder<String> esSinkBuilder = new ElasticsearchSink.Builder<
 );
 
 // configuration for the bulk requests; this instructs the sink to emit after every element, otherwise they would be buffered
-builder.setBulkFlushMaxActions(1);
+esSinkBuilder.setBulkFlushMaxActions(1);
 
 // provide a RestClientFactory for custom configuration on the internally created REST client
-builder.setRestClientFactory(
+esSinkBuilder.setRestClientFactory(
   restClientBuilder -> {
     restClientBuilder.setDefaultHeaders(...)
     restClientBuilder.setMaxRetryTimeoutMillis(...)
@@ -325,6 +326,7 @@ input.addSink(new ElasticsearchSink(config, transportAddresses, new Elasticsearc
 {% highlight scala %}
 import org.apache.flink.api.common.functions.RuntimeContext
 import org.apache.flink.streaming.api.datastream.DataStream
+import org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkFunction
 import org.apache.flink.streaming.connectors.elasticsearch.RequestIndexer
 import org.apache.flink.streaming.connectors.elasticsearch6.ElasticsearchSink
 
@@ -357,10 +359,10 @@ val esSinkBuilder = new ElasticsearchSink.Builer[String](
 )
 
 // configuration for the bulk requests; this instructs the sink to emit after every element, otherwise they would be buffered
-builder.setBulkFlushMaxActions(1)
+esSinkBuilder.setBulkFlushMaxActions(1)
 
 // provide a RestClientFactory for custom configuration on the internally created REST client
-builder.setRestClientFactory(
+esSinkBuilder.setRestClientFactory(
   restClientBuilder -> {
     restClientBuilder.setDefaultHeaders(...)
     restClientBuilder.setMaxRetryTimeoutMillis(...)


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services