You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/25 20:40:37 UTC

[GitHub] [geode] gesterzhou commented on a change in pull request #5530: GEODE-8517: GatewaySenderEventImpl's 2 new attributes were introduced…

gesterzhou commented on a change in pull request #5530:
URL: https://github.com/apache/geode/pull/5530#discussion_r495220452



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##########
@@ -710,7 +710,7 @@ public int getDSFID() {
   @Override
   public void toData(DataOutput out,
       SerializationContext context) throws IOException {
-    toDataPre_GEODE_1_13_0_0(out, context);
+    toDataPre_GEODE_1_14_0_0(out, context);
     boolean hasTransaction = this.transactionId != null;

Review comment:
       The version in toData() is 0. So it will not help. I added "if (version == 0 || version >= KnownVersion.GEODE_1_14_0.ordinal()) {" too. The result is the same. It did not improve on reproducing 49196. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org