You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/12 03:11:50 UTC

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9514: [Enhancement] Check status precise_code instead of construct OLAPInternalError

yiguolei commented on code in PR #9514:
URL: https://github.com/apache/incubator-doris/pull/9514#discussion_r870910837


##########
be/src/olap/utils.h:
##########
@@ -218,13 +218,10 @@ class Errno {
 };
 
 inline bool is_io_error(Status status) {

Review Comment:
   You'd better move this method to common/status.h



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org