You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/17 13:00:00 UTC
[jira] [Commented] (AIRFLOW-4328) Link to view task instances from
Pool broken
[ https://issues.apache.org/jira/browse/AIRFLOW-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820054#comment-16820054 ]
ASF GitHub Bot commented on AIRFLOW-4328:
-----------------------------------------
ashb commented on pull request #5124: [AIRFLOW-4328] Fix link to task instances from Pool page
URL: https://github.com/apache/airflow/pull/5124
Make sure you have checked _all_ steps below.
### Jira
- [ ] https://issues.apache.org/jira/browse/AIRFLOW-4328
### Description
- [ ] We want to link to the list of task instances that ran against this
pool, not to a specific task. (The link as it was wouldn't work, it was
missing lots of parameters, and wasn't meant to be. I messed up a
previous commit)
Rbac is fine.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Link to view task instances from Pool broken
> --------------------------------------------
>
> Key: AIRFLOW-4328
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4328
> Project: Apache Airflow
> Issue Type: Improvement
> Components: pools
> Affects Versions: 1.10.3
> Reporter: t oo
> Priority: Major
> Fix For: 1.10.4
>
>
> create some pool names (using cli) with 70 or 80 character length
>
> Q 1. UI does not allow creating > 50 length but why does cli?
>
> [https://domain:8080/admin/pool/]
> click on one of the pool names listed (link is cut to 50 char name: [https://domain:8080/admin/airflow/task?flt1_pool_equals=qjfdal_CRCE_INTERCONNECTION_FORECAST_TNC_EJFLSA_LP)]
> get below error:
> [2019-04-15 22:40:12,554] \{app.py:1761} ERROR - Exception on /admin/airflow/task [GET]
> Traceback (most recent call last):
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py", line 2292, in wsgi_app
> response = self.full_dispatch_request()
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py", line 1815, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py", line 1718, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py", line 1813, in full_dispatch_request
> rv = self.dispatch_request()
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py", line 1799, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask_admin/base.py", line 69, in inner
> return self._run_view(f, *args, **kwargs)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask_admin/base.py", line 368, in _run_view
> return fn(self, *args, **kwargs)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask_login/utils.py", line 261, in decorated_view
> return func(*args, **kwargs)
> File "/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/www/utils.py", line 275, in wrapper
> return f(*args, **kwargs)
> File "/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/www/views.py", line 893, in task
> dttm = pendulum.parse(execution_date)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parser.py", line 75, in parse
> return Parser(**options).parse(text)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parser.py", line 31, in parse
> parsed = super(Parser, self).parse(text)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parsing/parser.py", line 297, in parse
> return self.normalize(self._parse(text))
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parsing/parser.py", line 342, in _parse
> parsed = self.parse_common(text)
> File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parsing/parser.py", line 104, in parse_common
> m = self.COMMON.match(text)
> TypeError: expected string or buffer
> If click 'edit' it shows full 80chars in Description but cut 50chars in Pool
>
> Q2. why this large error? i believe its related to the fact that this is new airflow instance where no DAGs/tasks have run yet so it is expecting some execution_date value but none is there. Confirmed this as creating a new 3 letter pool name still gives the large error after clicking on the name of the created pool
> Q3. why limit to 50 length at all?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)