You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 10:15:36 UTC

[GitHub] [apisix] jenskeiner commented on pull request #2903: feat: Make headers to add to request in openid-connect plugin configurable.

jenskeiner commented on pull request #2903:
URL: https://github.com/apache/apisix/pull/2903#issuecomment-736377559


   > Please write new tests to cover your change, and make sure they are passed.
   
   I'm on it. I had a look at the existing structure and I'm relatively confident I can add more test cases to verify the setting of the respective headers.
   
   However, one thing is still unclear to me: There are cases already where token introspection is performed against a configured identity provider endpoint. The cases were added by @sshniro here: https://github.com/apache/apisix/commit/14f979edf84c5a76a96902cc2ab8e5697a905fe9
   
   Can anyone point me to the place where this introspection endpoint is set up for the tests? I can't find the corresponding code inside the project.
   
   I may need to add more dummy endpoints to verify the authorization flow in case a bearer token is not present in the incoming request and I want to make that consistent with the existing dummy introspection endpoint.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org