You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <ni...@gmail.com> on 2017/10/12 07:16:14 UTC
Review Request 62882: Good coding practice-add additional headers in
ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62882/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1828
https://issues.apache.org/jira/browse/RANGER-1828
Repository: ranger
Description
-------
Good coding practice-add additional headers in ranger.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44
Diff: https://reviews.apache.org/r/62882/diff/1/
Testing
-------
1)Verified if response contains additional headers on simple ranger(http).
2)Verified if response contains additional headers on kerberized ranger.
3)Verified if response contains additional headers on SSL ranger(https).
4)Verified if response contains additional headers on kerberized+SSL ranger.
Thanks,
Nikhil P
Re: Review Request 62882: Good coding practice-add additional headers
in ranger
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62882/#review187822
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java
Lines 144 (patched)
<https://reviews.apache.org/r/62882/#comment264870>
This should include "includeSubDomains"
https://www.owasp.org/index.php/HTTP_Strict_Transport_Security_Cheat_Sheet
- Alejandro Fernandez
On Oct. 12, 2017, 7:16 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62882/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 7:16 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1828
> https://issues.apache.org/jira/browse/RANGER-1828
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice-add additional headers in ranger.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44
>
>
> Diff: https://reviews.apache.org/r/62882/diff/1/
>
>
> Testing
> -------
>
> 1)Verified if response contains additional headers on simple ranger(http).
> 2)Verified if response contains additional headers on kerberized ranger.
> 3)Verified if response contains additional headers on SSL ranger(https).
> 4)Verified if response contains additional headers on kerberized+SSL ranger.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 62882: Good coding practice-add additional headers
in ranger
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62882/#review189112
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 17, 2017, 10:54 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62882/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:54 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1828
> https://issues.apache.org/jira/browse/RANGER-1828
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice-add additional headers in ranger.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44
>
>
> Diff: https://reviews.apache.org/r/62882/diff/2/
>
>
> Testing
> -------
>
> 1)Verified if response contains additional headers on simple ranger(http).
> 2)Verified if response contains additional headers on kerberized ranger.
> 3)Verified if response contains additional headers on SSL ranger(https).
> 4)Verified if response contains additional headers on kerberized+SSL ranger.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 62882: Good coding practice-add additional headers
in ranger
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62882/#review188343
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 17, 2017, 10:54 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62882/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:54 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1828
> https://issues.apache.org/jira/browse/RANGER-1828
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice-add additional headers in ranger.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44
>
>
> Diff: https://reviews.apache.org/r/62882/diff/2/
>
>
> Testing
> -------
>
> 1)Verified if response contains additional headers on simple ranger(http).
> 2)Verified if response contains additional headers on kerberized ranger.
> 3)Verified if response contains additional headers on SSL ranger(https).
> 4)Verified if response contains additional headers on kerberized+SSL ranger.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 62882: Good coding practice-add additional headers
in ranger
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62882/#review188924
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Oct. 17, 2017, 10:54 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62882/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:54 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1828
> https://issues.apache.org/jira/browse/RANGER-1828
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice-add additional headers in ranger.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44
>
>
> Diff: https://reviews.apache.org/r/62882/diff/2/
>
>
> Testing
> -------
>
> 1)Verified if response contains additional headers on simple ranger(http).
> 2)Verified if response contains additional headers on kerberized ranger.
> 3)Verified if response contains additional headers on SSL ranger(https).
> 4)Verified if response contains additional headers on kerberized+SSL ranger.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 62882: Good coding practice-add additional headers
in ranger
Posted by Nikhil P <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62882/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 4:24 p.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1828
https://issues.apache.org/jira/browse/RANGER-1828
Repository: ranger
Description
-------
Good coding practice-add additional headers in ranger.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 721dd44
Diff: https://reviews.apache.org/r/62882/diff/2/
Changes: https://reviews.apache.org/r/62882/diff/1-2/
Testing
-------
1)Verified if response contains additional headers on simple ranger(http).
2)Verified if response contains additional headers on kerberized ranger.
3)Verified if response contains additional headers on SSL ranger(https).
4)Verified if response contains additional headers on kerberized+SSL ranger.
Thanks,
Nikhil P