You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/11/12 09:18:42 UTC

[GitHub] storm pull request #2415: STORM-2811: Fix NPE in Nimbus when killing the sam...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2415

    STORM-2811: Fix NPE in Nimbus when killing the same topology multiple…

    … times, fix integration test killing the same topology multiple times
    
    https://issues.apache.org/jira/browse/STORM-2811
    
    Some of the integration tests don't create a TopoWrap, which causes the cleanup code to kill the same topology multiple times.
    
    The Nimbus client's behavior when the server throws exceptions was a little surprising to me. It looks like the client lost connection to the server after the NPE was thrown, so the subsequent atttempts to kill the topology just got TTransportException (I'm guessing the socket was closed). I'm not sure if this is expected behavior?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2811

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2415
    
----
commit d568408e4d284199cf53baed7dd1471ab9628ca4
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-11-12T09:11:49Z

    STORM-2811: Fix NPE in Nimbus when killing the same topology multiple times, fix integration test killing the same topology multiple times

----


---

[GitHub] storm pull request #2415: STORM-2811: Fix NPE in Nimbus when killing the sam...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2415


---

[GitHub] storm issue #2415: STORM-2811: Fix NPE in Nimbus when killing the same topol...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2415
  
    The test failure is likely due to https://issues.apache.org/jira/browse/STORM-2809. 
    
    I ran this change + a revert of https://github.com/apache/storm/pull/2363 6 times on Travis, and the only failure was when Travis somehow failed to start Maven. 14/15 runs locally (with the same revert) have passed, will investigate why the last run failed.


---