You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by Erick Tryzelaar <er...@gmail.com> on 2014/07/23 20:23:53 UTC
Review Request 23861: Up the zookeeper timeouts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23861/
-----------------------------------------------------------
Review request for Twill.
Repository: twill
Description
-------
Zookeeper runs a tad slow on my Macbook Pro, and tests weren't finishing within the time limits set in the unit tests. This patch ups those limits so `mvn test` passes.
Diffs
-----
twill-discovery-core/src/test/java/org/apache/twill/discovery/ZKDiscoveryServiceTest.java 0171b747b0e32c1c43670a6dff8356279e3b7398
twill-zookeeper/src/test/java/org/apache/twill/internal/zookeeper/LeaderElectionTest.java 468ba5974bd75289168043c174b8695bb7577b11
twill-zookeeper/src/test/java/org/apache/twill/zookeeper/ZKClientTest.java 40b0a3925f013a694c9ac9d401262cdd1f24ccce
Diff: https://reviews.apache.org/r/23861/diff/
Testing
-------
Thanks,
Erick Tryzelaar
Re: Review Request 23861: Up the zookeeper timeouts
Posted by Terence Yim <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23861/#review48549
-----------------------------------------------------------
Ship it!
Ship It!
- Terence Yim
On July 23, 2014, 6:23 p.m., Erick Tryzelaar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23861/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 6:23 p.m.)
>
>
> Review request for Twill.
>
>
> Repository: twill
>
>
> Description
> -------
>
> Zookeeper runs a tad slow on my Macbook Pro, and tests weren't finishing within the time limits set in the unit tests. This patch ups those limits so `mvn test` passes.
>
>
> Diffs
> -----
>
> twill-discovery-core/src/test/java/org/apache/twill/discovery/ZKDiscoveryServiceTest.java 0171b747b0e32c1c43670a6dff8356279e3b7398
> twill-zookeeper/src/test/java/org/apache/twill/internal/zookeeper/LeaderElectionTest.java 468ba5974bd75289168043c174b8695bb7577b11
> twill-zookeeper/src/test/java/org/apache/twill/zookeeper/ZKClientTest.java 40b0a3925f013a694c9ac9d401262cdd1f24ccce
>
> Diff: https://reviews.apache.org/r/23861/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erick Tryzelaar
>
>