You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ponymail.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2024/08/05 14:17:27 UTC
[I] Linking to emails that require authentication is confusing [incubator-ponymail-foal]
raboof opened a new issue, #263:
URL: https://github.com/apache/incubator-ponymail-foal/issues/263
When linking to an email that requires authentication, the UI shows the "An error occured" due to the 404 error reported by https://lists.apache.org/api/thread.lua . Users must first close the error box, and then use the 'profile' icon in the top-right to log in. This turns out to be non-obvious to some users, causing them to assume links to important information are broken and ignoring them.
I think it would be good to show page that makes it more obvious that you might need to log in on 404, or perhaps even consider returning a 401 from thread.lua in this case and redirect people to the login page automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [ponymail-foal]
Posted by "basantjamwal (via GitHub)" <gi...@apache.org>.
basantjamwal commented on issue #263:
URL: https://github.com/apache/ponymail-foal/issues/263#issuecomment-5811024863
Yes, sorry for the confusion. I've opened a PR here: #339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [ponymail-foal]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #263:
URL: https://github.com/apache/ponymail-foal/issues/263#issuecomment-5810824412
Did you mean to create a PR rather than an issue comment? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [incubator-ponymail-foal]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #263:
URL: https://github.com/apache/incubator-ponymail-foal/issues/263#issuecomment-4599966198
> As I recall, returning 404 for an email that requires auth is intentional. If a person is not authorised, they should not be able to determine if a private email exists or not.
I don't doubt this, but I think this is worth reconsidering.
> maybe it just needs to be made more obvious what to do?
I think so
> upon successful auth, the email will be displayed (if it exists and the user has karma). I think it's important that this feature is not lost if the error response is changed from a dialog to a page.
I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [incubator-ponymail-foal]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on issue #263:
URL: https://github.com/apache/incubator-ponymail-foal/issues/263#issuecomment-2269224421
As I recall, returning 404 for an email that requires auth is intentional. If a person is not authorised, they should not be able to determine if a private email exists or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [incubator-ponymail-foal]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on issue #263:
URL: https://github.com/apache/incubator-ponymail-foal/issues/263#issuecomment-4601576237
The corresponding UI for a private list is perhaps clearer, for example:
https://lists.apache.org/list.html?private@ponymail.apache.org
It includes a login link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [ponymail-foal]
Posted by "basantjamwal (via GitHub)" <gi...@apache.org>.
basantjamwal commented on issue #263:
URL: https://github.com/apache/ponymail-foal/issues/263#issuecomment-5810740766
Fixes #263
When a thread URL returns 404 (including private emails the user isn't logged in for), the error dialog said "you may need to be logged in" but gave no way to do it.
**Change**
- Add a "Log in" link (to `oauth.html`) to the error dialog on 404 responses.
- Applied to `webui/js/source/base-http-extensions.js` and the combined `webui/js/ponymail.js`.
**Notes**
- The API still returns 404, so private emails are not revealed.
- The link uses the same flow as the existing profile-menu login, which returns users to the page they came from.
**Testing**
- Served `webui/` locally and opened a thread URL with no backend, which gives a 404. The dialog shows the "Log in" link (screenshot below).
- Not tested against a real OAuth backend.
<img width="1920" height="1080" alt="Image" src="https://github.com/user-attachments/assets/3303a101-971c-45bd-a490-363847510e52" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [incubator-ponymail-foal]
Posted by "madrob (via GitHub)" <gi...@apache.org>.
madrob commented on issue #263:
URL: https://github.com/apache/incubator-ponymail-foal/issues/263#issuecomment-2269221862
I think there's something to be said for not disclosing the existence of an email when a user is unauthorised, but for most links where it's just a hash in the url and not even a list name, I don't think we're protecting much at the expense of a non obvious error message.
+1 to this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [incubator-ponymail-foal]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on issue #263:
URL: https://github.com/apache/incubator-ponymail-foal/issues/263#issuecomment-2269244292
The dialog box already says that the user may need to login; maybe it just needs to be made more obvious what to do?
Can the dialog box include a login button?
Note that one can click the login button without needing to close the dialog box first.
In either case, upon successful auth, the email will be displayed (if it exists and the user has karma).
I think it's important that this feature is not lost if the error response is changed from a dialog to a page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Linking to emails that require authentication is confusing [ponymail-foal]
Posted by "sebbASF (via GitHub) via issues" <is...@ponymail.apache.org>.
sebbASF closed issue #263: Linking to emails that require authentication is confusing
URL: https://github.com/apache/ponymail-foal/issues/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org