You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ja...@apache.org on 2014/08/26 01:39:37 UTC

svn commit: r1620484 - in /pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox: encoding/DictionaryEncoding.java pdmodel/font/PDType3Font.java

Author: jahewson
Date: Mon Aug 25 23:39:37 2014
New Revision: 1620484

URL: http://svn.apache.org/r1620484
Log:
PDFBOX-2262: Type 3 fonts have no built-in Encoding

Modified:
    pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/encoding/DictionaryEncoding.java
    pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType3Font.java

Modified: pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/encoding/DictionaryEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/encoding/DictionaryEncoding.java?rev=1620484&r1=1620483&r2=1620484&view=diff
==============================================================================
--- pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/encoding/DictionaryEncoding.java (original)
+++ pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/encoding/DictionaryEncoding.java Mon Aug 25 23:39:37 2014
@@ -82,6 +82,10 @@ public class DictionaryEncoding extends 
         {
             // and for a symbolic font, it is the font's built-in encoding."
             baseEncoding = builtIn;
+            if (builtIn == null)
+            {
+                throw new IllegalArgumentException("Built-in Encoding required for symbolic font");
+            }
             this.baseEncoding = null;
         }
 

Modified: pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType3Font.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType3Font.java?rev=1620484&r1=1620483&r2=1620484&view=diff
==============================================================================
--- pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType3Font.java (original)
+++ pdfbox/branches/no-awt/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType3Font.java Mon Aug 25 23:39:37 2014
@@ -63,7 +63,13 @@ public class PDType3Font extends PDSimpl
     @Override
     protected Encoding readEncodingFromFont() throws IOException
     {
-        return null;
+        throw new UnsupportedOperationException("not supported for Type 3 fonts");
+    }
+
+    @Override
+    public boolean isSymbolic()
+    {
+        return false;
     }
 
     @Override