You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/12/28 20:37:10 UTC
Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1701
https://issues.apache.org/jira/browse/FALCON-1701
Repository: falcon-git
Description
-------
HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
Diffs
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
Diff: https://reviews.apache.org/r/41749/diff/
Testing
-------
tested on nightly runs
Thanks,
Paul Isaychuk
Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Murali Ramasami <mu...@gmail.com>.
> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 316
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line316>
> >
> > label variable can be defined outside for loop and used accordingly.
Thanks. Modified the code accordingly.
> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java, line 161
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176964#file1176964line161>
> >
> > If the test is no longer valid , we should consider moving it out from code instead of disabling it.
Dev commented that "This test is invalid - If the table does not exist on target cluster there will be a failure." Ok. Will remove it from the test code.
> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 283
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line283>
> >
> > Java Doc missing ?
Will add the Java Doc information for checkErrorMessageByElement
> On Dec. 30, 2015, 6:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 272
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line272>
> >
> > Java Doc missing ?
Will add the Java Doc information for assertLocationsEqualError
- Murali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/#review112286
-----------------------------------------------------------
On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41749/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/41749/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/#review112286
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 272)
<https://reviews.apache.org/r/41749/#comment172682>
Java Doc missing ?
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 283)
<https://reviews.apache.org/r/41749/#comment172683>
Java Doc missing ?
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 316)
<https://reviews.apache.org/r/41749/#comment172687>
label variable can be defined outside for loop and used accordingly.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java (line 161)
<https://reviews.apache.org/r/41749/#comment172688>
If the test is no longer valid , we should consider moving it out from code instead of disabling it.
- PRAGYA MITTAL
On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41749/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/41749/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Murali Ramasami <mu...@gmail.com>.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 278
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line278>
> >
> > nit: I think you meant "Assertion for Working Location"
Yes. It is "Assertion for Working Location"
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 284
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line284>
> >
> > The purpose of the function seems to validate the error message for the element. If that is the case then will some other name like "checkErrorMessageByElement" be more descriptive?
Thanks Ajay. Make sense. Will change it to "checkErrorMessageByElement"
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 317
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line317>
> >
> > nit: remove the commented code please.
Removed the Commented Code.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 398
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line398>
> >
> > nit: remove dead code please.
Removed the Commented Code.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java, line 269
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176965#file1176965line269>
> >
> > The description is very usefual but the BUG ID looks like reference to a private or internal issue tracking system. Can you please refer Apache JIRA instead or edit the comment?
Removed the internal BUG ID from the patch.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java, line 288
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176965#file1176965line288>
> >
> > The description is very usefual but the BUG ID looks like reference to a private or internal issue tracking system. Can you please refer Apache JIRA instead or edit the comment?
Removed the internal BUG ID from the patch.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml, line 42
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176967#file1176967line42>
> >
> > Is the notification functionality tested somewhere in these tests or is it added for future use cases?
As part of the email notification feauture, we have added that for future use case and yet to be tested.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java, line 160
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176964#file1176964line160>
> >
> > Why is this test being disabled?
Dev commented that "This test is invalid - If the table does not exist on target cluster there will be a failure."
- Murali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/#review112202
-----------------------------------------------------------
On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41749/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/41749/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Murali Ramasami <mu...@gmail.com>.
> On Dec. 29, 2015, 7:23 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, line 400
> > <https://reviews.apache.org/r/41749/diff/1/?file=1176963#file1176963line400>
> >
> > This seems like a common requirement. Does it make sense to extract in some utility method?
Thanks Ajay. Make sense. Will create the utility for that.
- Murali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/#review112202
-----------------------------------------------------------
On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41749/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/41749/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41749/#review112202
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 278)
<https://reviews.apache.org/r/41749/#comment172535>
nit: I think you meant "Assertion for Working Location"
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 284)
<https://reviews.apache.org/r/41749/#comment172543>
The purpose of the function seems to validate the error message for the element. If that is the case then will some other name like "checkErrorMessageByElement" be more descriptive?
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 317)
<https://reviews.apache.org/r/41749/#comment172536>
nit: remove the commented code please.
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 398)
<https://reviews.apache.org/r/41749/#comment172538>
nit: remove dead code please.
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 400)
<https://reviews.apache.org/r/41749/#comment172537>
This seems like a common requirement. Does it make sense to extract in some utility method?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java (line 160)
<https://reviews.apache.org/r/41749/#comment172539>
Why is this test being disabled?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java (line 269)
<https://reviews.apache.org/r/41749/#comment172540>
The description is very usefual but the BUG ID looks like reference to a private or internal issue tracking system. Can you please refer Apache JIRA instead or edit the comment?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java (line 288)
<https://reviews.apache.org/r/41749/#comment172541>
The description is very usefual but the BUG ID looks like reference to a private or internal issue tracking system. Can you please refer Apache JIRA instead or edit the comment?
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml (line 42)
<https://reviews.apache.org/r/41749/#comment172542>
Is the notification functionality tested somewhere in these tests or is it added for future use cases?
- Ajay Yadava
On Dec. 28, 2015, 7:37 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41749/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java bcada4a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java 5efa5b2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 989e4b3
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/41749/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Paul Isaychuk
>
>