You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/03 18:01:04 UTC
[jira] [Commented] (BEAM-1199) Condense recordAsOutput,
finishSpecifyingOutput from POutput
[ https://issues.apache.org/jira/browse/BEAM-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995343#comment-15995343 ]
ASF GitHub Bot commented on BEAM-1199:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2864
[BEAM-1199] Remove POutput#recordAsOutput
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Add PValue#setDefaultName, for composite POutputs to use when they are
being finalized.
Expand POutput#finishSpecifyingOutput to take the name of the transform
that is being finished.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam condense_finish_output
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2864.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2864
----
commit cc04e3356f9232049a00babccd76e9b9f1630f67
Author: Thomas Groh <tg...@google.com>
Date: 2017-05-03T00:53:57Z
Remove POutput#recordAsOutput
Add PValue#setDefaultName, for composite POutputs to use when they are
being finalized.
Expand POutput#finishSpecifyingOutput to take the name of the transform
that is being finished.
----
> Condense recordAsOutput, finishSpecifyingOutput from POutput
> ------------------------------------------------------------
>
> Key: BEAM-1199
> URL: https://issues.apache.org/jira/browse/BEAM-1199
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Kenneth Knowles
> Priority: Minor
> Fix For: First stable release
>
>
> {{recordAsOutput}} and {{finishSpecifyingOutput}} are both methods which are called after an output has been attached to a PTransform application. They can be combined to only have one method that does any after-production work (such as the initial run of Coder inference)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)