You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/10/24 11:37:40 UTC
[PR] MINOR: Fix a maybe-uninitialized warning [arrow]
js8544 opened a new pull request, #38433:
URL: https://github.com/apache/arrow/pull/38433
Some compilers generate a maybe-uninitialized warning when compiling scalar_round.cc
```
/home/jinshang/arrow/cpp/src/arrow/util/logging.h: In function 'void arrow::compute::internal::RegisterScalarRoundArithmetic(arrow::compute::FunctionRegistry*)':
/home/jinshang/arrow/cpp/src/arrow/util/logging.h:59:34: warning: 'exec' may be used uninitialized [-Wmaybe-uninitialized]
59 | #define ARROW_IGNORE_EXPR(expr) ((void)(expr))
| ^
/home/jinshang/arrow/cpp/src/arrow/compute/kernels/scalar_round.cc:1262:23: note: 'exec' was declared here
1262 | ArrayKernelExec exec;
| ^~~~
/home/jinshang/arrow/cpp/src/arrow/util/logging.h:59:34: warning: 'exec' may be used uninitialized [-Wmaybe-uninitialized]
59 | #define ARROW_IGNORE_EXPR(expr) ((void)(expr))
| ^
/home/jinshang/arrow/cpp/src/arrow/compute/kernels/scalar_round.cc:1283:23: note: 'exec' was declared here
1283 | ArrayKernelExec exec;
| ^~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix a maybe-uninitialized warning [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38433:
URL: https://github.com/apache/arrow/pull/38433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix a maybe-uninitialized warning [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on PR #38433:
URL: https://github.com/apache/arrow/pull/38433#issuecomment-1778395783
Looks okay to me.
cc @pitrou could you please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix a maybe-uninitialized warning [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38433:
URL: https://github.com/apache/arrow/pull/38433#issuecomment-1781928475
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c655c33fdf72d86e24cc4a1c1f977c48ea868039.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18100376269) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org