[jira] [Commented] (ARROW-5853) [Python] Expose boolean filter kernel on Array

["Blake Haugen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884816#comment-16884816 ] 

Blake Haugen commented on ARROW-5853:
-------------------------------------

I would like to work on this issue to get familiar with the codebase so my apologies if this is a dumb question. I think I have something partially working but I am wondering what the expected behavior is if you pass something like an integer array as the filter.

When I passed it an integer array of 0s and 1s I get a seg fault. My C++ is pretty rusty but in poking around in 'filter.cc' I suspect it may be something related to the 'checked_pointer_cast' in 'FilterKernel::Call'.

It doesn't look like there are any C++ tests with an array other than BooleanArray. Should this function check that the Array is boolean and throw a type error if it isn't or should this be doing a different cast?

> [Python] Expose boolean filter kernel on Array
> ----------------------------------------------
>
>                 Key: ARROW-5853
>                 URL: https://issues.apache.org/jira/browse/ARROW-5853
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Joris Van den Bossche
>            Priority: Major
>
> Expose the filter kernel (https://issues.apache.org/jira/browse/ARROW-1558) on the python Array class.
> Could be done as {{.filter(mask)}} method and/or in {{\_\_getitem\_\_}}.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)