You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Vimal Sharma <vi...@hortonworks.com> on 2016/10/04 11:13:38 UTC
Re: Review Request 52257: Return system attributes in get entity
definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
-----------------------------------------------------------
(Updated Oct. 4, 2016, 11:13 a.m.)
Review request for atlas.
Changes
-------
Updated the patch and addressed Shweta's and Suma's comments
Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916
Repository: atlas
Description
-------
Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 263ea46
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 5c7cb2e
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 2e0414e
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 9e656a5
Diff: https://reviews.apache.org/r/52257/diff/
Testing (updated)
-------
Testing done with Hive table creation and updation
Thanks,
Vimal Sharma
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Oct. 24, 2016, 8:10 p.m., Suma Shivaprasad wrote:
> > Ship It!
Pls fix below comments
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153729
-----------------------------------------------------------
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153729
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On Oct. 24, 2016, 10:27 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java, line 137
> > <https://reviews.apache.org/r/52257/diff/3/?file=1539513#file1539513line137>
> >
> > The Index should be of String type..not Long here?
Thanks for catching this. Silly mistake!
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153749
-----------------------------------------------------------
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153749
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java (line 137)
<https://reviews.apache.org/r/52257/#comment223163>
The Index should be of String type..not Long here?
- Suma Shivaprasad
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
> On Oct. 24, 2016, 11:51 p.m., Suma Shivaprasad wrote:
> > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java, line 188
> > <https://reviews.apache.org/r/52257/diff/3/?file=1539518#file1539518line188>
> >
> > can you add test for querying by these system attributes as well?
Query test for attributes TIMESTAMP_PROPERTY_KEY and MODIFICATION_TIMESTAMP_PROPERTY_KEY were already present. Added query test for CREATED_BY_KEY and MODIFIED_BY_KEY.
- Vimal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153763
-----------------------------------------------------------
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153763
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java (line 188)
<https://reviews.apache.org/r/52257/#comment223169>
can you add test for querying by these system attributes as well?
- Suma Shivaprasad
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review156180
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 529)
<https://reviews.apache.org/r/52257/#comment226316>
Tests fail due to NullPointerException in GremlinTest
- Vimal Sharma
On Nov. 16, 2016, 1:33 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 1:33 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review156288
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Nov. 18, 2016, 7:15 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2016, 7:15 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
-----------------------------------------------------------
(Updated Nov. 18, 2016, 7:15 a.m.)
Review request for atlas.
Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916
Repository: atlas
Description
-------
Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
Diff: https://reviews.apache.org/r/52257/diff/
Testing
-------
Testing done with Hive table creation and updation
Thanks,
Vimal Sharma
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review156176
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 529)
<https://reviews.apache.org/r/52257/#comment226310>
why can't the default be null, if not set? Same for other properties
- Shwetha GS
On Nov. 16, 2016, 1:33 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 1:33 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
-----------------------------------------------------------
(Updated Nov. 16, 2016, 1:33 p.m.)
Review request for atlas.
Changes
-------
Made changes suggested by Shwetha
Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916
Repository: atlas
Description
-------
Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
Diff: https://reviews.apache.org/r/52257/diff/
Testing
-------
Testing done with Hive table creation and updation
Thanks,
Vimal Sharma
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review156026
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java (line 78)
<https://reviews.apache.org/r/52257/#comment226126>
Use TypeSystem.getInstance().getDateFormat
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java (line 87)
<https://reviews.apache.org/r/52257/#comment226125>
Should return Date object to avoid the confusion of the date format used in string
- Shwetha GS
On Nov. 15, 2016, 4:33 p.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 4:33 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
-----------------------------------------------------------
(Updated Nov. 15, 2016, 4:33 p.m.)
Review request for atlas.
Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916
Repository: atlas
Description
-------
Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
Diff: https://reviews.apache.org/r/52257/diff/
Testing
-------
Testing done with Hive table creation and updation
Thanks,
Vimal Sharma
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Nov. 14, 2016, 7:49 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java, line 161
> > <https://reviews.apache.org/r/52257/diff/4/?file=1562618#file1562618line161>
> >
> > do we need composite for modification timestamp? It will help in equals match only and I dont see how that would be useful.
I see a use for Mixed index though
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review155836
-----------------------------------------------------------
On Nov. 14, 2016, 4:50 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 4:50 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review155836
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java (line 161)
<https://reviews.apache.org/r/52257/#comment225931>
do we need composite for modification timestamp? It will help in equals match only and I dont see how that would be useful.
- Suma Shivaprasad
On Nov. 14, 2016, 4:50 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 4:50 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
-----------------------------------------------------------
(Updated Nov. 14, 2016, 4:50 a.m.)
Review request for atlas.
Changes
-------
Fixed review comments
Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916
Repository: atlas
Description
-------
Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
common/src/main/java/org/apache/atlas/repository/Constants.java cc184a5
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54fa
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 725b9a6
typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
Diff: https://reviews.apache.org/r/52257/diff/
Testing
-------
Testing done with Hive table creation and updation
Thanks,
Vimal Sharma
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153762
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java (line 133)
<https://reviews.apache.org/r/52257/#comment223168>
why do we need a composite index only on the attribute. Would recommend creating by typeName + modifiedTime since DSK always adds the typeName . If needed we will add the individual index later
- Suma Shivaprasad
On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 11:44 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
> typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/
-----------------------------------------------------------
(Updated Oct. 17, 2016, 11:44 a.m.)
Review request for atlas.
Changes
-------
Rebased the patch. Moved sytem attributes to a new class outside of Id. Added tests as suggested by Suma
Bugs: ATLAS-916
https://issues.apache.org/jira/browse/ATLAS-916
Repository: atlas
Description
-------
Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 47ae5e1
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 13b7d22
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 7a57518
typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
Diff: https://reviews.apache.org/r/52257/diff/
Testing
-------
Testing done with Hive table creation and updation
Thanks,
Vimal Sharma
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151360
-----------------------------------------------------------
typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala (line 94)
<https://reviews.apache.org/r/52257/#comment219694>
can we add valid date data in the tests? Also can you add a test for these keys in GraphBackedDiscoveryServiceTest.
- Suma Shivaprasad
On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 11:13 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 263ea46
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 5c7cb2e
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 2e0414e
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 9e656a5
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151362
-----------------------------------------------------------
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java (line 54)
<https://reviews.apache.org/r/52257/#comment219696>
sorry didnt notice this earlier. Didnt get why these were added as part of the Id? They dont uniquely identify an entity and should not go into the Id IMO.
- Suma Shivaprasad
On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 11:13 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 263ea46
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 5c7cb2e
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 2e0414e
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 9e656a5
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Oct. 4, 2016, 6:14 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java, line 295
> > <https://reviews.apache.org/r/52257/diff/2/?file=1519962#file1519962line295>
> >
> > can we add asserts in getEntityDefintion for these props?
I meant in tests
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151364
-----------------------------------------------------------
On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 11:13 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 263ea46
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 5c7cb2e
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 2e0414e
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 9e656a5
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151364
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java (line 295)
<https://reviews.apache.org/r/52257/#comment219698>
can we add asserts in getEntityDefintion for these props?
- Suma Shivaprasad
On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 11:13 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 263ea46
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 5c7cb2e
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 2e0414e
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 9e656a5
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>
Re: Review Request 52257: Return system attributes in get entity
definition
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151357
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java (line 239)
<https://reviews.apache.org/r/52257/#comment219692>
Dont see any indexes created on these properties in GraphbackedSearchIndexer
- Suma Shivaprasad
On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 11:13 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-916
> https://issues.apache.org/jira/browse/ATLAS-916
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas should maintain system attributes created time, last modified time, created by user and last modified by user for every entity. This information should be returned in get entity definition
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b
> common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 263ea46
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 5c7cb2e
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 2e0414e
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b3526
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 9e656a5
>
> Diff: https://reviews.apache.org/r/52257/diff/
>
>
> Testing
> -------
>
> Testing done with Hive table creation and updation
>
>
> Thanks,
>
> Vimal Sharma
>
>