You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "michallenc (via GitHub)" <gi...@apache.org> on 2026/08/05 08:08:37 UTC

Re: [PR] !nshlib: Require explicit fixed login password at build time [nuttx-apps]

michallenc commented on code in PR #3557:
URL: https://github.com/apache/nuttx-apps/pull/3557#discussion_r3718975891


##########
nshlib/Kconfig:
##########
@@ -1230,32 +1230,30 @@ config NSH_LOGIN
 config NSH_CONSOLE_LOGIN
 	bool "Console Login"
 	default n
+	depends on FSUTILS_PASSWD

Review Comment:
   I am getting a little late to this (we've updated our NuttX repositories and found this change now), but why is the dependency enforced? Why does the password need to be verified against the file? I understand the benefits, but why enforce the option. This should be optional, not mandatory. @Abhishekmishra2808 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org