You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/16 13:40:32 UTC

[GitHub] [cordova-plugin-camera] ishanAhuja commented on a change in pull request #426: (android) allowEdit not working when sourceType is PHOTOLIBRARY

ishanAhuja commented on a change in pull request #426: (android) allowEdit not working when sourceType is PHOTOLIBRARY
URL: https://github.com/apache/cordova-plugin-camera/pull/426#discussion_r284711290
 
 

 ##########
 File path: src/android/CameraLauncher.java
 ##########
 @@ -101,8 +101,10 @@ Licensed to the Apache Software Foundation (ASF) under one
 
     private static final String LOG_TAG = "CameraLauncher";
 
-    //Where did this come from?
-    private static final int CROP_CAMERA = 100;
+    //Crop Codes
+    private static final int CROP_OPERATION = 100;
+    private static final int CROP_CAMERA = CROP_OPERATION;
+    private static final int CROP_PHOTO_ALBUM = CROP_OPERATION + 900;
 
 Review comment:
   Hey @timbru31, why 900 specifically? Is there a reason for it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org