You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jinho Kim <jh...@apache.org> on 2014/03/24 07:46:48 UTC

Review Request 19576: TAJO-701: Invalid bytes when creating BlobDatum with offset

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19576/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-701
    https://issues.apache.org/jira/browse/TAJO-701


Repository: tajo


Description
-------

If BlobDatum create with shared bytes, it return wrong bytes.


Diffs
-----

  tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java 4c4f557 
  tajo-common/src/test/java/org/apache/tajo/datum/TestBytesDatum.java af2d814 

Diff: https://reviews.apache.org/r/19576/diff/


Testing
-------

mvn clean install


Thanks,

Jinho Kim


Re: Review Request 19576: TAJO-701: Invalid bytes when creating BlobDatum with offset

Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19576/#review38410
-----------------------------------------------------------

Ship it!


+1

It looks good, and 'mvn clean install' finished successfully.

- Jung JaeHwa


On March 24, 2014, 6:46 a.m., Jinho Kim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19576/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 6:46 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-701
>     https://issues.apache.org/jira/browse/TAJO-701
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> If BlobDatum create with shared bytes, it return wrong bytes.
> 
> 
> Diffs
> -----
> 
>   tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java 4c4f557 
>   tajo-common/src/test/java/org/apache/tajo/datum/TestBytesDatum.java af2d814 
> 
> Diff: https://reviews.apache.org/r/19576/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Jinho Kim
> 
>