You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/02/17 06:03:18 UTC

[GitHub] junichi11 commented on issue #425: Netbeans 352

junichi11 commented on issue #425: Netbeans 352
URL: https://github.com/apache/incubator-netbeans/pull/425#issuecomment-366419921
 
 
   Maybe I'm not a proper person to review this. So, I just would like to say about your git commits.
   
   It would be nice if you can rebase & squash your commits yourself (see https://git-scm.com/book/id/v2/Git-Tools-Rewriting-History).
   
   You should add the issue number([NetBeans-352]) to your commit message. (see other PRs and Contribution Guidelines (4): https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408#SubmittingPullRequestonApacheNetBeans(incubating)-ContributionGuidelines)
   
   Thanks for your work!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists