[jira] [Commented] (ATLAS-1184) ReservedTypesRegistrar checks for existence of 1st class type

["Shwetha G S (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509686#comment-15509686 ] 

Shwetha G S commented on ATLAS-1184:
------------------------------------

Looks like ReservedTypesRegistrar uses internal APIs directly. It should just be a utility which uses rest APIs so that its audited

> ReservedTypesRegistrar checks for existence of 1st class type
> -------------------------------------------------------------
>
>                 Key: ATLAS-1184
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1184
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Vimal Sharma
>
> ReservedTypesRegistrar registers the models for supported integrations like hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files and registers the types defined in the model file. The check thats done to verify if the model is already registered - checks for existence of first class type. This will not work if we add more class types to the existing model or modify the existing type to add optional attributes. 
> ReservedTypesRegistrar should check for every type in the model file. Also, ReservedTypesRegistrar should do type update which does create if not exists, and update if exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)