[GitHub] [iceberg] rdblue commented on a diff in pull request #5602: Core: Add expression JSON parser

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5602:
URL: https://github.com/apache/iceberg/pull/5602#discussion_r950904217


##########
api/src/main/java/org/apache/iceberg/expressions/BoundReference.java:
##########
@@ -26,10 +26,12 @@
 public class BoundReference<T> implements BoundTerm<T>, Reference<T> {
   private final Types.NestedField field;
   private final Accessor<StructLike> accessor;
+  private final String name;
 
-  BoundReference(Types.NestedField field, Accessor<StructLike> accessor) {
+  BoundReference(Types.NestedField field, Accessor<StructLike> accessor, String name) {
     this.field = field;
     this.accessor = accessor;
+    this.name = name;

Review Comment:
   Tracking the field name was needed to handle bound expressions. This is also a good thing to track for other purposes (e.g., easier to read log messages with bound expressions).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org