[GitHub] [hive] kuczoram commented on a change in pull request #1775: HIVE-24530: Potential NPE in FileSinkOperator.closeRecordwriters method

[GitBox <gi...@apache.org>]

kuczoram commented on a change in pull request #1775:
URL: https://github.com/apache/hive/pull/1775#discussion_r543173097



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
##########
@@ -1204,8 +1205,10 @@ private void closeWriters(boolean abort) throws HiveException {
   private void closeRecordwriters(boolean abort) {
     for (RecordWriter writer : rowOutWriters) {

Review comment:
       You're right, I added a null check for the rowOutWriters as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org